From owner-cvs-src@FreeBSD.ORG  Wed Mar 29 05:41:23 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 785B016A41F;
	Wed, 29 Mar 2006 05:41:23 +0000 (UTC) (envelope-from des@des.no)
Received: from tim.des.no (tim.des.no [194.63.250.121])
	by mx1.FreeBSD.org (Postfix) with ESMTP id AE1A743D48;
	Wed, 29 Mar 2006 05:41:22 +0000 (GMT) (envelope-from des@des.no)
Received: from tim.des.no (localhost [127.0.0.1])
	by spam.des.no (Postfix) with ESMTP id 25C0D2096;
	Wed, 29 Mar 2006 07:41:17 +0200 (CEST)
X-Spam-Tests: AWL,BAYES_00,FORGED_RCVD_HELO
X-Spam-Learn: ham
X-Spam-Score: -2.4/3.0
X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on tim.des.no
Received: from xps.des.no (des.no [80.203.243.180])
	by tim.des.no (Postfix) with ESMTP id 9A7CC2081;
	Wed, 29 Mar 2006 07:41:16 +0200 (CEST)
Received: by xps.des.no (Postfix, from userid 1001)
	id 7474633C8D; Wed, 29 Mar 2006 07:41:16 +0200 (CEST)
From: des@des.no (Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?=)
To: Alexander Kabaev <kabaev@gmail.com>
References: <200603281828.k2SIS7wM052478@repoman.freebsd.org>
	<20060328200901.56a5ed09@kan.dnsalias.net>
Date: Wed, 29 Mar 2006 07:41:16 +0200
In-Reply-To: <20060328200901.56a5ed09@kan.dnsalias.net> (Alexander Kabaev's
	message of "Tue, 28 Mar 2006 20:09:01 -0500")
Message-ID: <86acb9vmdf.fsf@xps.des.no>
User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.3 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/libexec/rtld-elf/i386 rtld_machdep.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Mar 2006 05:41:23 -0000

Alexander Kabaev <kabaev@gmail.com> writes:
> Dag-Erling Smorgrav <des@FreeBSD.org> wrote:
> >   Log:
> >   Don't use dbg if it isn't defined (such as when this file is used by
> >   code outside of rtld-elf)
> The use of this file in threading libraries is illegal and should be
> fixed instead.

That was my initial reaction as well, but you can't get around the
fact that the thread libraries need to know about linker internals.
It might be better to reorganize rtld's header files so there is a
clear division between data structures (which the thread libraries
need to know about) and implementation details (which they don't).

DES
--=20
Dag-Erling Sm=F8rgrav - des@des.no