From owner-cvs-sys Fri May 1 08:13:39 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id IAA27137 for cvs-sys-outgoing; Fri, 1 May 1998 08:13:39 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id IAA27085; Fri, 1 May 1998 08:13:03 -0700 (PDT) (envelope-from peter@FreeBSD.org) From: Peter Wemm Received: (from peter@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id IAA14728; Fri, 1 May 1998 08:11:00 -0700 (PDT) Date: Fri, 1 May 1998 08:11:00 -0700 (PDT) Message-Id: <199805011511.IAA14728@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/kern vfs_bio.c Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk peter 1998/05/01 08:11:00 PDT Modified files: sys/kern vfs_bio.c Log: vm_page_is_valid() wasn't expecting a large offset argument, it's expecting a sub-page offset. We were passing the file position, and vm_page_bits() could do some interesting things when base was larger PAGE_SIZE. if (size > PAGE_SIZE - base) size = PAGE_SIZE - base; is interesting when (PAGE_SIZE - base) is negative. I could imagine that this could have interesting consequences for memory page -> device block bit validation. Revision Changes Path 1.164 +3 -2 src/sys/kern/vfs_bio.c