From owner-p4-projects@FreeBSD.ORG  Thu Jun 26 10:57:28 2003
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 37CD537B405; Thu, 26 Jun 2003 10:57:28 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id AFD5737B404
	for <perforce@freebsd.org>; Thu, 26 Jun 2003 10:57:27 -0700 (PDT)
Received: from mail.speakeasy.net (mail9.speakeasy.net [216.254.0.209])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A40E343FBD
	for <perforce@freebsd.org>; Thu, 26 Jun 2003 10:57:26 -0700 (PDT)
	(envelope-from jhb@FreeBSD.org)
Received: (qmail 11408 invoked from network); 26 Jun 2003 17:57:26 -0000
Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63])
	(envelope-sender <jhb@FreeBSD.org>)encrypted SMTP
	for <perforce@freebsd.org>; 26 Jun 2003 17:57:26 -0000
Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1])
	by server.baldwin.cx (8.12.9/8.12.9) with ESMTP id h5QHvOGI059669;
	Thu, 26 Jun 2003 13:57:24 -0400 (EDT)
	(envelope-from jhb@FreeBSD.org)
Message-ID: <XFMail.20030626135736.jhb@FreeBSD.org>
X-Mailer: XFMail 1.5.4 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <200306252205.h5PM5lga058117@repoman.freebsd.org>
Date: Thu, 26 Jun 2003 13:57:36 -0400 (EDT)
From: John Baldwin <jhb@FreeBSD.org>
To: Peter Wemm <peter@FreeBSD.org>
cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: RE: PERFORCE change 33663 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Jun 2003 17:57:29 -0000


On 25-Jun-2003 Peter Wemm wrote:
> http://perforce.freebsd.org/chv.cgi?CH=33663
> 
> Change 33663 by peter@peter_hammer on 2003/06/25 15:05:09
> 
>       Port sym to amd64

This is possibly not correct.  Do all hammer's support the P3+
SFENCE and related instructions?  Even i386 should probably be
using what bus_space_barrier() uses.  Heck, sym should probably
just be using bus_space_barrier anyways.

> Affected files ...
> 
> .. //depot/projects/hammer/sys/dev/sym/sym_hipd.c#6 edit
> 
> Differences ...
> 
> ==== //depot/projects/hammer/sys/dev/sym/sym_hipd.c#6 (text+ko) ====
> 
> @@ -162,7 +162,7 @@
>   *  make sense) to be used.
>   */
>  
> -#if  defined __i386__
> +#if  defined __i386__ || defined __amd64__
>  #define MEMORY_BARRIER()     do { ; } while(0)
>  #elif        defined __alpha__
>  #define MEMORY_BARRIER()     alpha_mb()

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/