From owner-freebsd-arch Mon Mar 12 12:33:32 2001 Delivered-To: freebsd-arch@freebsd.org Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id 6D2CA37B71C for ; Mon, 12 Mar 2001 12:33:24 -0800 (PST) (envelope-from imp@harmony.village.org) Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.11.1/8.11.1) with ESMTP id f2CKXJI39387 for ; Mon, 12 Mar 2001 13:33:23 -0700 (MST) (envelope-from imp@harmony.village.org) Message-Id: <200103122033.f2CKXJI39387@harmony.village.org> To: arch@FreeBSD.ORG Subject: Re: Breaking up make.conf In-reply-to: Your message of "Mon, 12 Mar 2001 12:22:43 PST." <20010312122243.A26946@dragon.nuxi.com> References: <20010312122243.A26946@dragon.nuxi.com> <200103090241.SAA27525@gndrsh.dnsmgr.net> <200103090349.f293nGs04577@billy-club.village.org> <200103090430.f294Ucs04824@billy-club.village.org> <200103090449.f294nUs06142@billy-club.village.org> <20010310170844.C36413@dragon.nuxi.com> <200103110145.f2B1jOI23270@harmony.village.org> <20010312112939.E21123@dragon.nuxi.com> <200103121934.f2CJYZI38844@harmony.village.org> <20010312114142.B21989@dragon.nuxi.com> <200103121945.f2CJjPI39044@harmony.village.org> Date: Mon, 12 Mar 2001 13:33:19 -0700 From: Warner Losh Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message <20010312122243.A26946@dragon.nuxi.com> "David O'Brien" writes: : > But this is pointless. Unless you go and include a new file at the : > start of every makefile in the tree changing the bsd.*.mk files to : > include the global config file is meaningless because it is too late. : : Not pointless. A required first step, if we decided we do want to move : the change the Makefiles. IF you want to add .include I'd be OK with that from a bsd.*.mk point of view. It is likely tedious and error prone, and only really needed for about 20 Makefiles in the tree. Most of the rest can cope without needed to go into and do that. The rest could include this indirectly from bsd.{prog,lib,subdir}.mk. Something like that would allow us to have bsd.conf.mk look like .if !target(__bsd_conf_mk) WORLD_CONF?=/etc/make.world.conf .include "${WORLD_CONF}" .include __bsd_conf_mk: .endif and allow third parties to also have their own definition of WORLD_CONF, either in their environment or as part of their wrappers. There would then be issues with . We could avoid those issues by removing bsd.cpu.mk from sys.mk and putting it in bsd.conf.mk like I've done above. Also, there might need to be some makefile foo done to prevent __bsd_conf_mk: from becoming the default target. Something like this serves the needs of the world build, but is also hackable/extensible for others using the system. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message