From owner-freebsd-ports  Tue Nov 14  1:36:44 2000
Delivered-To: freebsd-ports@freebsd.org
Received: from mailrouter1.strath.ac.uk (orkney.cc.strath.ac.uk [130.159.248.40])
	by hub.freebsd.org (Postfix) with ESMTP
	id 8501837B4C5; Tue, 14 Nov 2000 01:36:41 -0800 (PST)
Received: from m109-mp1-cvx1b.ren.ntl.com ([62.252.136.109] helo=cs.strath.ac.uk)
	by mailrouter1.strath.ac.uk with esmtp (Exim 3.12 #2)
	id 13vcVi-00024E-00; Tue, 14 Nov 2000 09:36:14 +0000
Message-ID: <3A11077A.C31A158A@cs.strath.ac.uk>
Date: Tue, 14 Nov 2000 09:35:54 +0000
From: Roger Hardiman <roger@cs.strath.ac.uk>
Organization: Strathclyde University
X-Mailer: Mozilla 4.51 [en] (X11; I; FreeBSD 4.1.1-STABLE i386)
X-Accept-Language: en
MIME-Version: 1.0
To: asami@FreeBSD.org
Cc: ports@freebsd.org
Subject: Adding AUTOMAKE_FLAGS to bsd.port.mk
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-RBL-Warning: (dul.maps.vix.com) See <URL:http://mail-abuse.org/dul/>
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

Hi,

Please can you consider this change to bsd.ports.mk

It follows on from the audio/libao, audio/libogg, 
audio/vorbis-tools and audio/libvorbis  ports I have
been fixing recently.


The Problem
-----------
These 4 ports need to pass the '--add-missing' parameter
to AUTOMAKE.


So, I'd like to define a new variable AUTOMAKE_ARGS
and change bsd.port.mk from this:

  .if defined(USE_AUTOMAKE)
        @(cd ${CONFIGURE_WRKSRC} && ${AUTOMAKE})
  .endif

to this:
  .if defined(USE_AUTOMAKE)
        @(cd ${CONFIGURE_WRKSRC} && ${AUTOMAKE} ${AUTOMAKE_ARGS})
  .endif


Then, in the port Makefiles I can put

USE_AUTOMAKE= yes
AUTOMAKE_ARGS += --add-missing.


This makes the Port Makefile nice and clean and consistent
with other parts of the Port System which allow arguments
to be passed , eg CONFIGURE_ARGS


What do you think to this change?

Roger
--
Roger Hardiman
Strathclyde Uni Telepresence Research Group, Glasgow, Scotland.
http://www.telepresence.strath.ac.uk      0141 548 2897
roger@cs.strath.ac.uk


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message