Date: Tue, 15 Aug 2000 21:10:03 -0700 (PDT) From: Will Andrews <andrews@technologist.com> To: freebsd-ports@FreeBSD.org Subject: Re: ports/20618: New port: moviedb, the internet movie database Message-ID: <200008160410.VAA61002@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/20618; it has been noted by GNATS.
From: Will Andrews <andrews@technologist.com>
To: sluggo@unknown.nu
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: ports/20618: New port: moviedb, the internet movie database
Date: Tue, 15 Aug 2000 18:58:15 -0400
On Tue, Aug 15, 2000 at 10:21:35AM -0500, sluggo@unknown.nu wrote:
> >Synopsis: New port: moviedb, the internet movie database
Thanks. However..:
> # /usr/ports/misc/moviedb
^^^^^^^^^^^^^^^^
Should not be in the shar because it forces position. Like, maybe
people would prefer to put it in a working directory or something
instead of here.
Proper way to shar this would be like:
cd /usr/ports/misc
shar `find moviedb` > moviedb.shar
[..send moviedb.shar..]
> XDISTFILES=3D tools/${PORTNAME}-${PORTVERSION}${EXTRACT_SUFX} actors.=
list.gz actresses.list.gz aka-names.list.gz aka-titles.list.gz alternate-ve=
rsions.list.gz biographies.list.gz business.list.gz certificates.list.gz ci=
nematographers.list.gz color-info.list.gz complete-cast.list.gz complete-cr=
ew.list.gz composers.list.gz costume-designers.list.gz countries.list.gz cr=
azy-credits.list.gz directors.list.gz distributors.list.gz editors.list.gz =
genres.list.gz german-aka-titles.list.gz goofs.list.gz iso-aka-titles.list.=
gz italian-aka-titles.list.gz keywords.list.gz language.list.gz laserdisc.l=
ist.gz literature.list.gz locations.list.gz miscellaneous.list.gz movie-lin=
ks.list.gz movies.list.gz mpaa-ratings-reasons.list.gz plot.list.gz produce=
rs.list.gz production-companies.list.gz production-designers.list.gz quotes=
.list.gz ratings.list.gz release-dates.list.gz running-times.list.gz sound-=
mix.list.gz soundtracks.list.gz special-effects-companies.list.gz taglines.=
list.gz technical.!
This is a big no-no (wrapping lines unnecessarily). Use this:
DISTFILES=3D tools/${DISTNAME}${EXTRACT_SUFX} actors.list.gz \
actresses.list.gz aka-names.list.gz aka-titles.list.gz \
[...] \
[...]
Repeat for other lists like that. Or, to save space, you can have this:
> XIGNOREFILES=3D actors.list.gz actresses.list.gz aka-names.list.gz ak=
a-titles.list.gz alternate-versions.list.gz biographies.list.gz business.li=
st.gz certificates.list.gz cinematographers.list.gz color-info.list.gz comp=
lete-cast.list.gz complete-crew.list.gz composers.list.gz costume-designers=
.list.gz countries.list.gz crazy-credits.list.gz directors.list.gz distribu=
tors.list.gz editors.list.gz genres.list.gz german-aka-titles.list.gz goofs=
.list.gz iso-aka-titles.list.gz italian-aka-titles.list.gz keywords.list.gz=
language.list.gz laserdisc.list.gz literature.list.gz locations.list.gz mi=
scellaneous.list.gz movie-links.list.gz movies.list.gz mpaa-ratings-reasons=
.list.gz plot.list.gz producers.list.gz production-companies.list.gz produc=
tion-designers.list.gz quotes.list.gz ratings.list.gz release-dates.list.gz=
running-times.list.gz sound-mix.list.gz soundtracks.list.gz special-effect=
s-companies.list.gz taglines.list.gz technical.list.gz trivia.list.gz write=
rs.list.gz
properly delimited as I said above, then include ${IGNOREFILES} in
DISTFILES like:
DISTFILES=3D tools/${DISTNAME}${EXTRACT_SUFX} ${IGNOREFILES}
> X ${INSTALL_SCRIPT} ${WRKSRC}/etc/lfetch ${PREFIX}/libexec/moviedb/
> X ${INSTALL_SCRIPT} ${WRKSRC}/etc/make-base ${PREFIX}/libexec/moviedb/
> X ${INSTALL_SCRIPT} ${WRKSRC}/etc/recompress ${PREFIX}/libexec/moviedb/
Use a for script (in make syntax) to prevent repetition and make the
Makefile more scalable.
=2Efor SCRIPT in lfetch make-base recompress
${INSTALL_SCRIPT} ${WRKSRC}/etc/${SCRIPT} ${PREFIX}/libexec/moviedb
=2Eendfor
> Xpost-install:
> X strip ${PREFIX}/bin/alist
> X strip ${PREFIX}/bin/lformat
> X strip ${PREFIX}/bin/lguide
> X strip ${PREFIX}/bin/lindex
> X strip ${PREFIX}/bin/list
> X strip ${PREFIX}/bin/listall
> X strip ${PREFIX}/bin/lseen
> X strip ${PREFIX}/bin/ltrace
> X strip ${PREFIX}/bin/mkballot
> X strip ${PREFIX}/bin/template
> X strip ${PREFIX}/bin/templist
> X strip ${PREFIX}/bin/title
> X strip ${PREFIX}/libexec/moviedb/mkdb
> X.if !defined(NOPORTDOCS)
> X ${MKDIR} ${PREFIX}/share/doc/moviedb
> X ${INSTALL_DATA} ${WRKSRC}/docs/ADDS-GUIDE ${PREFIX}/share/doc/moviedb
> X ${INSTALL_DATA} ${WRKSRC}/docs/ChangeLog ${PREFIX}/share/doc/moviedb
> X ${INSTALL_DATA} ${WRKSRC}/docs/FAQ ${PREFIX}/share/doc/moviedb
> X ${INSTALL_DATA} ${WRKSRC}/docs/FUTURES ${PREFIX}/share/doc/moviedb
> X ${INSTALL_DATA} ${WRKSRC}/docs/INSTRUCTIONS ${PREFIX}/share/doc/moviedb
> X ${INSTALL_DATA} ${WRKSRC}/docs/manual.tex ${PREFIX}/share/doc/moviedb
> X.endif
See above.
> XMD5 (moviedb/actors.list.gz) =3D IGNORE
> XMD5 (moviedb/actresses.list.gz) =3D IGNORE
> XMD5 (moviedb/aka-names.list.gz) =3D IGNORE
> XMD5 (moviedb/aka-titles.list.gz) =3D IGNORE
> XMD5 (moviedb/alternate-versions.list.gz) =3D IGNORE
> XMD5 (moviedb/biographies.list.gz) =3D IGNORE
> XMD5 (moviedb/business.list.gz) =3D IGNORE
> XMD5 (moviedb/certificates.list.gz) =3D IGNORE
> XMD5 (moviedb/cinematographers.list.gz) =3D IGNORE
> XMD5 (moviedb/color-info.list.gz) =3D IGNORE
> XMD5 (moviedb/complete-cast.list.gz) =3D IGNORE
> XMD5 (moviedb/complete-crew.list.gz) =3D IGNORE
> XMD5 (moviedb/composers.list.gz) =3D IGNORE
> XMD5 (moviedb/costume-designers.list.gz) =3D IGNORE
> XMD5 (moviedb/countries.list.gz) =3D IGNORE
> XMD5 (moviedb/crazy-credits.list.gz) =3D IGNORE
> XMD5 (moviedb/directors.list.gz) =3D IGNORE
> XMD5 (moviedb/distributors.list.gz) =3D IGNORE
> XMD5 (moviedb/editors.list.gz) =3D IGNORE
> XMD5 (moviedb/genres.list.gz) =3D IGNORE
> XMD5 (moviedb/german-aka-titles.list.gz) =3D IGNORE
> XMD5 (moviedb/goofs.list.gz) =3D IGNORE
> XMD5 (moviedb/iso-aka-titles.list.gz) =3D IGNORE
> XMD5 (moviedb/italian-aka-titles.list.gz) =3D IGNORE
> XMD5 (moviedb/keywords.list.gz) =3D IGNORE
> XMD5 (moviedb/language.list.gz) =3D IGNORE
> XMD5 (moviedb/laserdisc.list.gz) =3D IGNORE
> XMD5 (moviedb/literature.list.gz) =3D IGNORE
> XMD5 (moviedb/locations.list.gz) =3D IGNORE
> XMD5 (moviedb/miscellaneous.list.gz) =3D IGNORE
> XMD5 (moviedb/movie-links.list.gz) =3D IGNORE
> XMD5 (moviedb/movies.list.gz) =3D IGNORE
> XMD5 (moviedb/mpaa-ratings-reasons.list.gz) =3D IGNORE
> XMD5 (moviedb/plot.list.gz) =3D IGNORE
> XMD5 (moviedb/producers.list.gz) =3D IGNORE
> XMD5 (moviedb/production-companies.list.gz) =3D IGNORE
> XMD5 (moviedb/production-designers.list.gz) =3D IGNORE
> XMD5 (moviedb/quotes.list.gz) =3D IGNORE
> XMD5 (moviedb/ratings.list.gz) =3D IGNORE
> XMD5 (moviedb/release-dates.list.gz) =3D IGNORE
> XMD5 (moviedb/running-times.list.gz) =3D IGNORE
> XMD5 (moviedb/sound-mix.list.gz) =3D IGNORE
> XMD5 (moviedb/soundtracks.list.gz) =3D IGNORE
> XMD5 (moviedb/special-effects-companies.list.gz) =3D IGNORE
> XMD5 (moviedb/taglines.list.gz) =3D IGNORE
> XMD5 (moviedb/technical.list.gz) =3D IGNORE
> XMD5 (moviedb/trivia.list.gz) =3D IGNORE
> XMD5 (moviedb/writers.list.gz) =3D IGNORE
I'm not sure I like the idea of the MD5 checksums of these files being
ignored...
> XPLEASE NOTE! This is a large port; as of August 2000, it requires over
> X300MB free to install.
Probably should move this to the Makefile, in pre-fetch target, so
people will have a chance to cancel if they wish, before they download
things.
PLIST looks good.
There are some minor tweaks I'd suggest in the patches, like using sed
or perl regex in the Makefile for removing some of the options instead
of having to recreate patchfiles every time you update (i.e. make the
port more scalable across new versions).
Thanks for your work.. (Good luck to the committer that tests this
port, 'cause I don't have 400MB of space to spare at the moment)
--=20
Will Andrews <andrewsw@purdue.edu> <will@FreeBSD.org>
GCS/E/S @d- s+:+ a--- C++ UB++++$ P+ L- E--- W+ N-- !o ?K w---
O- M+ V- PS+ PE++ Y+ PGP+>+++ t++ 5 X+ R+ tv+ b++ DI+++ D+=20
G++ e>++++ h! r- y?
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200008160410.VAA61002>