From owner-svn-src-head@freebsd.org Tue May 15 16:32:15 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C545FEE6600; Tue, 15 May 2018 16:32:15 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from smtp.freebsd.org (unknown [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 77D2475DD9; Tue, 15 May 2018 16:32:15 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from mail-it0-f53.google.com (mail-it0-f53.google.com [209.85.214.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) (Authenticated sender: mmacy) by smtp.freebsd.org (Postfix) with ESMTPSA id 3DF242117E; Tue, 15 May 2018 16:32:15 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: by mail-it0-f53.google.com with SMTP id n202-v6so3053501ita.1; Tue, 15 May 2018 09:32:15 -0700 (PDT) X-Gm-Message-State: ALKqPwfKE3DuJP3Hef5/5M20AOC2uw0tlAxSzONA8ABRsMyPeM98bUNG SLKd53lXIUhKQOXsd0u6O/CCcX76v1Jxh1Awwhs= X-Google-Smtp-Source: AB8JxZr37vpLgQBVsZVucc50bSgmJZmui5D058GrkaAo0A031tfmFec4xYgZFyZ+OJjs8kVhlcbduagR809sePrOi4w= X-Received: by 2002:a6b:3b42:: with SMTP id i63-v6mr16500324ioa.133.1526401934664; Tue, 15 May 2018 09:32:14 -0700 (PDT) MIME-Version: 1.0 References: <201805080139.w481djMX062724@repo.freebsd.org> <20180515161843.GA63058@raichu> In-Reply-To: <20180515161843.GA63058@raichu> From: Matthew Macy Date: Tue, 15 May 2018 09:32:03 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r333345 - head/sys/dev/e1000 To: Mark Johnston Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 May 2018 16:32:16 -0000 See r333631 On Tue, May 15, 2018 at 09:18 Mark Johnston wrote: > On Tue, May 08, 2018 at 01:39:45AM +0000, Matt Macy wrote: > > Author: mmacy > > Date: Tue May 8 01:39:45 2018 > > New Revision: 333345 > > URL: https://svnweb.freebsd.org/changeset/base/333345 > > > > Log: > > Sleep rather than spin in e1000 when doing long running config > operations. > > > > With r333218 it is now possible for drivers to use an sx lock and thus > sleep while > > waiting on long running operations rather than DELAY(). > > > > Reported by: gallatin > > Reviewed by: sbruno > > Approved by: sbruno > > MFC after: 1 month > > Sponsored by: Limelight Networks > > Differential Revision: https://reviews.freebsd.org/D14984 > > This commit causes igb to fail to attach to one of the ports on an I210: > > igb0@pci0:5:0:0: class=0x020000 card=0x153315d9 chip=0x15338086 > rev=0x03 hdr=0x00 > vendor = 'Intel Corporation' > device = 'I210 Gigabit Network Connection' > class = network > subclass = ethernet > igb1@pci0:6:0:0: class=0x020000 card=0x153315d9 chip=0x15338086 > rev=0x03 hdr=0x00 > vendor = 'Intel Corporation' > device = 'I210 Gigabit Network Connection' > class = network > subclass = ethernet > > In the dmesg I see: > > igb0: port 0xd000-0xd01f > mem 0xf8300000-0xf837ffff,0xf8380000-0xf8383fff irq 18 at device 0.0 > numa-domain 0 on pci6 > igb0: attach_pre capping queues at 4 > igb0: Setup of Shared code failed, error -2 > igb0: IFDI_ATTACH_PRE failed 6 > device_attach: igb0 attach returned 6 > pcib7: irq 19 at device 28.3 numa-domain 0 on pci1 > pci7: numa-domain 0 on pcib7 > igb0: port 0xc000-0xc01f > mem 0xf8200000-0xf827ffff,0xf8280000-0xf8283fff irq 19 at device 0.0 > numa-domain 0 on pci7 > igb0: attach_pre capping queues at 4 > igb0: using 1024 tx descriptors and 1024 rx descriptors > igb0: msix_init qsets capped at 4 > igb0: pxm cpus: 8 queue msgs: 4 admincnt: 1 > igb0: using 4 rx queues 4 tx queues > igb0: Using MSIX interrupts with 5 vectors > igb0: allocated for 4 tx_queues > igb0: allocated for 4 rx_queues >