From nobody Fri Apr 24 07:48:33 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g24pG4ppJz6ZhyK for ; Fri, 24 Apr 2026 07:48:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g24pG386Jz48Pw for ; Fri, 24 Apr 2026 07:48:38 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777016918; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=A1OelZ2uactqx5Pq4XrSFUNOW21WIIIUS793DmSY9vo=; b=bJl8qPhLYJEqXDpL/DZbjpOSsSHYih3DRr9lASxpB6e/KnW6PfbI3iRJfgD5YiyO6RIkuk LNn6d6zNGwuuKcw5A9IjFQq3VUKpsHo+ZSwfC6CTNClG2qHgV4/X7NUBrd6vPqEM30ppIL bmvnDPr7ssgpdtyHX7EKhQSww6mBWMDqEW/BR0poqKsdy2DzaRGKkWQCEP42z7c5je3+mp q2xVjG1UoUHlcVkXAV6k/M64bnpmOib3T+/pFao6t3pNHOWrPhowLcP9XDODdgqGB28+s3 4d5WDXdUxHnRrA3+lNdFw54LaMzl/GmXNRIF0x71Q0fg4+Hi/6/CEys4G7PebA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1777016918; a=rsa-sha256; cv=none; b=k6z0IHwdgbhtRCPNGK7n85pcP3Fmhcvv5tqbTMOW+r09WqDYN4Mz3QD8gjrj4Lc67Yy8np Z6jx68UhDj2GwgoFAPihQslO/TaVCC0+l+LaiVej2s2R1bs6T4mPfObQ5CXVAET3L1BbnK DrZIO3Q2l76zERVaTbGMPbiG6sdSz0F7hBHfmoiusfPiVcoHpgix6sGMpPiw3TphIcxvxb Ht7UN4+6h8WlCY3uFAvJg2APuU34+DxKBT0mh21iObJE4Ugqywf8HWmunAV3A5gkhJO0/p alQfwDa/EOffAX5is9/JBQD77uVgkVQLGWSB8fZIygEKG2Oy1HCOw3Apx2afgg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777016918; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=A1OelZ2uactqx5Pq4XrSFUNOW21WIIIUS793DmSY9vo=; b=veHUEtCzp8Wvm4/9u5ATquDioXjCN/VNfTXtkuhCPIge/GlIxyJrnCH317ePzDgzIOoLaB npo+TeRORU87fufPO/dOTVLWYIXb3x0cjotNjtd0zEe/j07r/0AywOvR9DthTGOoi7FyF2 knG98TBa8fT+CvguA6YviJ+oXuKWFG9TI6iAEmCTWSW3ev+Rjd/5SlP/X9eLLcrG8QagdQ CnV//N+ZoUB3dcXzYBOqgfiFDgsD1sWQ0POlrpIxeD0SP+r/GpRxnm5QiGunRzM+EH01pR HRrmvut8bQptMt8F1dsqGzCDjTMGsWolcuKhbSQxGfznw0Kv9jzlTRRsFkVuug== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g24pG1W9qztyv for ; Fri, 24 Apr 2026 07:48:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 24b9f by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 24 Apr 2026 07:48:33 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Johan=?utf-8?Q? S=C3=B6llv?=ander Subject: git: eb837cb8b207 - main - ctld: normalize iSCSI TargetName on login List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: js X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: eb837cb8b2073c09bafaf3318f5bb103827b2bca Auto-Submitted: auto-generated Date: Fri, 24 Apr 2026 07:48:33 +0000 Message-Id: <69eb2051.24b9f.e879694@gitrepo.freebsd.org> The branch main has been updated by js: URL: https://cgit.FreeBSD.org/src/commit/?id=eb837cb8b2073c09bafaf3318f5bb103827b2bca commit eb837cb8b2073c09bafaf3318f5bb103827b2bca Author: Johan Söllvander AuthorDate: 2026-04-24 07:44:43 +0000 Commit: Johan Söllvander CommitDate: 2026-04-24 07:44:43 +0000 ctld: normalize iSCSI TargetName on login Case-insensitive TargetName matching on logins was accidentally removed, let's fix that by normalizing TargetName again according to RFC 3722. PR: 294522 Fixes: 4b1aac931465f39c5c26bfa1d5539a428d340f20 Sponsored by: ConnectWise MFC after: 1 week Reviewed by: asomers, jhb Approved by: asomers (mentor) Differential Revision: https://reviews.freebsd.org/D56469 --- usr.sbin/ctld/login.cc | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/usr.sbin/ctld/login.cc b/usr.sbin/ctld/login.cc index cda11cc1f21b..fb4b60c37f54 100644 --- a/usr.sbin/ctld/login.cc +++ b/usr.sbin/ctld/login.cc @@ -967,12 +967,18 @@ iscsi_connection::login() login_send_error(request, 0x02, 0x07); log_errx(1, "received Login PDU without TargetName"); } + /* + * Normalize target_name according to RFC 3722 + */ + std::string t_name(target_name); + for (char &c : t_name) + c = tolower(c); - conn_port = pg->find_port(target_name); + conn_port = pg->find_port(t_name); if (conn_port == NULL) { login_send_error(request, 0x02, 0x03); log_errx(1, "requested target \"%s\" not found", - target_name); + t_name.c_str()); } conn_target = conn_port->target(); }