From owner-freebsd-bluetooth@FreeBSD.ORG Thu Feb 16 07:47:25 2006 Return-Path: X-Original-To: freebsd-bluetooth@freebsd.org Delivered-To: freebsd-bluetooth@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2BE5116A420; Thu, 16 Feb 2006 07:47:25 +0000 (GMT) (envelope-from Alexander@Leidinger.net) Received: from www.ebusiness-leidinger.de (jojo.ms-net.de [84.16.236.246]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3F2C443D46; Thu, 16 Feb 2006 07:47:24 +0000 (GMT) (envelope-from Alexander@Leidinger.net) Received: from Andro-Beta.Leidinger.net (p54A5EC58.dip.t-dialin.net [84.165.236.88]) (authenticated bits=0) by www.ebusiness-leidinger.de (8.13.1/8.13.1) with ESMTP id k1G7Yswa054547; Thu, 16 Feb 2006 08:34:55 +0100 (CET) (envelope-from Alexander@Leidinger.net) Received: from localhost (localhost [127.0.0.1]) by Andro-Beta.Leidinger.net (8.13.3/8.13.3) with ESMTP id k1G7lHXQ048690; Thu, 16 Feb 2006 08:47:17 +0100 (CET) (envelope-from Alexander@Leidinger.net) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde MIME library) with HTTP; Thu, 16 Feb 2006 08:47:17 +0100 Message-ID: <20060216084717.yyj986z4ckow4w0w@netchild.homeip.net> X-Priority: 3 (Normal) Date: Thu, 16 Feb 2006 08:47:17 +0100 From: Alexander Leidinger To: Markus Brueffer References: <200602151551.27188.markus@brueffer.de> In-Reply-To: <200602151551.27188.markus@brueffer.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Internet Messaging Program (IMP) H3 (4.0.3) / FreeBSD-4.11 X-Virus-Scanned: by amavisd-new Cc: freebsd-bluetooth@freebsd.org, freebsd-usb@freebsd.org Subject: Re: [Patch] Fix collection entry parsing in libusbhid X-BeenThere: freebsd-bluetooth@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Using Bluetooth in FreeBSD environments List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Feb 2006 07:47:25 -0000 Markus Brueffer wrote: > Furthermore I have removed the loop in REPORT_SAVED_COLL. If someone > knows why > it was there in the first place, please share your wisdom :) This is done in many places in the source. It's a common way of writting a macro which is usable like a function (yes, this macro returns, so it doesn't _work_ like a function, but this is not the point). Usually this is used with macros which take arguments. You just can add a ';' after the use of the macro without having to remember if you need to do it, or if your compiler may moan because of an empty statement. Have a look into style(9), it also has to say something about it. Bye, Alexander. -- http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 ANDROPHOBIA: Fear of men.