From owner-freebsd-usb@FreeBSD.ORG  Sun Nov  7 20:28:48 2004
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
Delivered-To: freebsd-usb@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1F54E16A4CE
	for <freebsd-usb@freebsd.org>; Sun,  7 Nov 2004 20:28:48 +0000 (GMT)
Received: from sccrmhc12.comcast.net (sccrmhc12.comcast.net [204.127.202.56])
	by mx1.FreeBSD.org (Postfix) with ESMTP id AF08B43D2D
	for <freebsd-usb@freebsd.org>; Sun,  7 Nov 2004 20:28:47 +0000 (GMT)
	(envelope-from rodrigc@crodrigues.org)
Received: from h00609772adf0.ne.client2.attbi.com ([66.30.114.143])
          by comcast.net (sccrmhc12) with ESMTP
          id <20041107202846012009rcdme>; Sun, 7 Nov 2004 20:28:46 +0000
Received: from h00609772adf0.ne.client2.attbi.com (localhost [127.0.0.1])
	iA7KSlWm097038;	Sun, 7 Nov 2004 15:28:47 -0500 (EST)
	(envelope-from rodrigc@h00609772adf0.ne.client2.attbi.com)
Received: (from rodrigc@localhost)iA7KSkRD097037;
	Sun, 7 Nov 2004 15:28:46 -0500 (EST)	(envelope-from rodrigc)
Date: Sun, 7 Nov 2004 15:28:46 -0500
From: Craig Rodrigues <rodrigc@crodrigues.org>
To: "M. Warner Losh" <imp@bsdimp.com>
Message-ID: <20041107202846.GA97021@crodrigues.org>
References: <20041107064227.GA79915@crodrigues.org>
	<20041107.125814.34760598.imp@bsdimp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20041107.125814.34760598.imp@bsdimp.com>
User-Agent: Mutt/1.4.1i
cc: freebsd-usb@freebsd.org
Subject: Re: Changing permissions of /dev/usb[n] to 664?
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 07 Nov 2004 20:28:48 -0000

On Sun, Nov 07, 2004 at 12:58:14PM -0700, M. Warner Losh wrote:
> This looks good, but we should audit all the ioctls to make sure the
> ones that modify anything have the proper checks to make sure the fd
> was opened for write.

I started doing that.  These are the ioctl's:

USB_DISCOVER  ->  this is a no-op,
USB_REQUEST
USB_DEVICEINFO
USB_DEVICE_STATS

I did not see any of these ioctl's do any permission checks on the fd,
so my patch probably not ready yet.

-- 
Craig Rodrigues        
http://crodrigues.org
rodrigc@crodrigues.org