Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 7 Nov 2004 15:28:46 -0500
From:      Craig Rodrigues <rodrigc@crodrigues.org>
To:        "M. Warner Losh" <imp@bsdimp.com>
Cc:        freebsd-usb@freebsd.org
Subject:   Re: Changing permissions of /dev/usb[n] to 664?
Message-ID:  <20041107202846.GA97021@crodrigues.org>
In-Reply-To: <20041107.125814.34760598.imp@bsdimp.com>
References:  <20041107064227.GA79915@crodrigues.org> <20041107.125814.34760598.imp@bsdimp.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Nov 07, 2004 at 12:58:14PM -0700, M. Warner Losh wrote:
> This looks good, but we should audit all the ioctls to make sure the
> ones that modify anything have the proper checks to make sure the fd
> was opened for write.

I started doing that.  These are the ioctl's:

USB_DISCOVER  ->  this is a no-op,
USB_REQUEST
USB_DEVICEINFO
USB_DEVICE_STATS

I did not see any of these ioctl's do any permission checks on the fd,
so my patch probably not ready yet.

-- 
Craig Rodrigues        
http://crodrigues.org
rodrigc@crodrigues.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041107202846.GA97021>