From owner-freebsd-fs@freebsd.org Tue Feb 14 19:22:07 2017 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D9BFBCDFD6F for ; Tue, 14 Feb 2017 19:22:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C945B1B66 for ; Tue, 14 Feb 2017 19:22:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v1EJM7XY030739 for ; Tue, 14 Feb 2017 19:22:07 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-fs@FreeBSD.org Subject: [Bug 217062] for file systems mounted with -o noexec, exec=off property does not work for mmap Date: Tue, 14 Feb 2017 19:22:07 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: kib@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Feb 2017 19:22:07 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217062 --- Comment #4 from Konstantin Belousov --- (In reply to shamaz.mazum from comment #3) The fragment you cited is exactly the cause why mprotect(2) call in your te= st program fails. mprotect(2) checks that new protection is a subset of the maxprot. That said, my opinion is that disallowing PROT_EXEC for mappings from -o no= exec mounts is useless. If you determined, there is nothing which could prevent= you from mapping anonymous memory, copying data from the file into it, and then executing. OTOH, I admit that there is inconsistency between mmap(2) and mprotect(2), which was introduced by r127187. The patch I attached fixes that, but I wo= nder would it be more useful to revert the mentioned revision instead. --=20 You are receiving this mail because: You are the assignee for the bug.=