From owner-freebsd-current@FreeBSD.ORG Tue Sep 6 08:45:53 2005 Return-Path: X-Original-To: current@FreeBSD.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E3BFC16A41F; Tue, 6 Sep 2005 08:45:53 +0000 (GMT) (envelope-from phk@phk.freebsd.dk) Received: from haven.freebsd.dk (haven.freebsd.dk [130.225.244.222]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8FED343D45; Tue, 6 Sep 2005 08:45:53 +0000 (GMT) (envelope-from phk@phk.freebsd.dk) Received: from phk.freebsd.dk (unknown [192.168.48.2]) by haven.freebsd.dk (Postfix) with ESMTP id 2EFECBC6B; Tue, 6 Sep 2005 08:45:52 +0000 (UTC) To: Don Lewis From: "Poul-Henning Kamp" In-Reply-To: Your message of "Tue, 06 Sep 2005 01:41:45 PDT." <200509060841.j868fj1I032057@gw.catspoiler.org> Date: Tue, 06 Sep 2005 10:45:51 +0200 Message-ID: <64186.1125996351@phk.freebsd.dk> Sender: phk@phk.freebsd.dk Cc: current@FreeBSD.org Subject: Re: patch for ext2fs unmount problem at shutdown X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Sep 2005 08:45:54 -0000 In message <200509060841.j868fj1I032057@gw.catspoiler.org>, Don Lewis writes: >I suspect both that is one possible reason, and another reason would be >to avoid marking the file system clean if any writes timed out. In that case the unmount should fail, otherwise the filesystem is buggy. >> I think we should do away with the nbusy check, including the 35 >> lines of softupdate magic and call vfs_unmountall() in all circumstances >> (but retain the check for !cold, RB_NOSYNC and panic). >> >> Instead we should add a flag to VFS_UNMOUNT that means "don't hang >> forever" and use that in vfs_unmountall(). > >That makes sense longer term, but for quite some time we've had a number >of users who have been rather unhappy to find out that every time they >reboot with a mounted ext2fs file system that *all* of their file >systems are marked dirty and require attention from fsck. I am really not keen on adding more magic features to the buffer cache if we can get the same effect by taking away code. Considering that our kernel presently tend to explode violently on disk errors I would say that the nbusy check should just be commented out for now and vfs_unmountall() always tried. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.