From nobody Fri Jun 17 19:37:10 2022 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 8507085A70C; Fri, 17 Jun 2022 19:37:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LPq7C2Sbmz3PSX; Fri, 17 Jun 2022 19:37:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1655494631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0Ex4/gIcja4ovPaOiu+zv5iVB2LNK+l6dPuq8W3PAY4=; b=aQG4JN35COK5Q47k7CqoIXBHJ/oUHV6cnNgoL7NsXc/fqnrFD3rlgX+VK+AMkhDv4kn72A gSl7eFSJ+jXGDc6edlPJHt8FFVEz3bx2SSvLFySAlROAGLWMQWzpn50In/w36sIEJe76Z2 eI0GqV3Qs5ZEtTKYQ+jzbaeD4yPm39Vo5A/K0FCISzxLzB7AXkgL4ooIyuIqbHa9pZxbeo 7cD+VdBzV41TmLAif9xWJrF7uSsBaA5XXMfTbCycvjuXYW1vOhuTIUtx9r2++fdRefAZxs sFKWClwRY2tDEc1i17o5pGewWWEGPEot/qnEIu9qot7uHcsSu8GonnOtJfjmUQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id C5A8325A30; Fri, 17 Jun 2022 19:37:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 25HJbA2S013009; Fri, 17 Jun 2022 19:37:10 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 25HJbA3F013008; Fri, 17 Jun 2022 19:37:10 GMT (envelope-from git) Date: Fri, 17 Jun 2022 19:37:10 GMT Message-Id: <202206171937.25HJbA3F013008@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dmitry Chagin Subject: git: ee847258e369 - stable/13 - linux(4): Eliminate bogus comment. List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dchagin X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: ee847258e3691118ef00bbec0ff7c85471018b60 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1655494631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0Ex4/gIcja4ovPaOiu+zv5iVB2LNK+l6dPuq8W3PAY4=; b=lVSmdwQkrx4RaRpH92IJoeCiy5kNrYmZ1u6Yyz+ZMQGasIYEcTdDDQb3tFHXdEKACEoL8v eZYDT8Xt+7Obwv26kTMatjMlLFu091YdrMPAgMmF/DtlPuP/6RcGjKp9tA1z+Is9hTXNRV 8cHXk0uxG6PZKYL/3nTrQV4nwquXnvNm89KevEXzFq7rdPxVVZYgMADmOUutt1Rnabomw8 6jN/0xWKbHNpEJn1wu4f9uyfdp4otmz71H0hTbKgQ12vTA7LLqWeVwuJ9vqbjlKa2xWNIa zlOfzCtavmNMl92CV8MN0u7zx8OGdndsm600c5tHkUhJLdBqA3Orcz1phCwryw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1655494631; a=rsa-sha256; cv=none; b=Al+X5gMsknI9eIN3DulleifZQqjrGCHKA5NIVcpI/ztfh9Uba7Iz7VSKMAlPUM19Cc8inJ mUN0Izas8uYawa1ZaIZHofEVBuda6qJG7Wjug2gQK5FXf6s98AdDXzpHTiRi2axKFMLm0n +J0uW920ONzPDaU5+ISNMjUcTGiT7mjsxOLuMkucSx7usXnwmvuCV5J/W5mAXfRKDdmrQL +a0upKGXjnq7KbODJhlFdA8ReXlguLzCkIlm9lMQdi+kTI7JksW8QORYAhYhtFXCbZGhwr sraadPGN4brxlwcoOn2qvgIaP4rVDqFDDdzptrJNaDWlvB5XfDsivKCBsVMJhA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by dchagin: URL: https://cgit.FreeBSD.org/src/commit/?id=ee847258e3691118ef00bbec0ff7c85471018b60 commit ee847258e3691118ef00bbec0ff7c85471018b60 Author: Dmitry Chagin AuthorDate: 2021-07-20 11:39:56 +0000 Commit: Dmitry Chagin CommitDate: 2022-06-17 19:33:12 +0000 linux(4): Eliminate bogus comment. For the caller is no need for access checking here, as the caller must take care of EFAULT handling. Moreover, this check would be superfluous, since EFAULT is extremily rare, and we prefer the fast path. MFC after: 2 weeks (cherry picked from commit 80b8d6b144c2f22dda252efe0d9fc70a1c8e15b7) --- sys/compat/linux/linux_futex.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/sys/compat/linux/linux_futex.c b/sys/compat/linux/linux_futex.c index 2ee18c26cf24..f69b13585022 100644 --- a/sys/compat/linux/linux_futex.c +++ b/sys/compat/linux/linux_futex.c @@ -115,7 +115,6 @@ LIN_SDT_PROBE_DEFINE3(futex, futex_requeue, requeue, "uint32_t *", LIN_SDT_PROBE_DEFINE1(futex, futex_wait, sleep_error, "int"); LIN_SDT_PROBE_DEFINE4(futex, futex_atomic_op, decoded_op, "int", "int", "int", "int"); -LIN_SDT_PROBE_DEFINE0(futex, futex_atomic_op, missing_access_check); LIN_SDT_PROBE_DEFINE1(futex, futex_atomic_op, unimplemented_op, "int"); LIN_SDT_PROBE_DEFINE1(futex, futex_atomic_op, unimplemented_cmp, "int"); LIN_SDT_PROBE_DEFINE0(futex, linux_futex, unimplemented_clockswitch); @@ -591,9 +590,6 @@ futex_atomic_op(struct thread *td, int encoded_op, uint32_t *uaddr) LIN_SDT_PROBE4(futex, futex_atomic_op, decoded_op, op, cmp, oparg, cmparg); - /* XXX: Linux verifies access here and returns EFAULT */ - LIN_SDT_PROBE0(futex, futex_atomic_op, missing_access_check); - switch (op) { case FUTEX_OP_SET: ret = futex_xchgl(oparg, uaddr, &oldval);