From owner-p4-projects@FreeBSD.ORG  Thu Jun 16 19:43:22 2005
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id D2C2716A420; Thu, 16 Jun 2005 19:43:21 +0000 (GMT)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id ACC4A16A41C
	for <perforce@freebsd.org>; Thu, 16 Jun 2005 19:43:21 +0000 (GMT)
	(envelope-from jhb@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9AAD543D1F
	for <perforce@freebsd.org>; Thu, 16 Jun 2005 19:43:21 +0000 (GMT)
	(envelope-from jhb@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j5GJhLTe046066
	for <perforce@freebsd.org>; Thu, 16 Jun 2005 19:43:21 GMT
	(envelope-from jhb@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j5GJhLMa046063
	for perforce@freebsd.org; Thu, 16 Jun 2005 19:43:21 GMT
	(envelope-from jhb@freebsd.org)
Date: Thu, 16 Jun 2005 19:43:21 GMT
Message-Id: <200506161943.j5GJhLMa046063@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	jhb@freebsd.org using -f
From: John Baldwin <jhb@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 78647 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Jun 2005 19:43:23 -0000

http://perforce.freebsd.org/chv.cgi?CH=78647

Change 78647 by jhb@jhb_slimer on 2005/06/16 19:42:33

	Add some extra witness checks to catch threads exiting with locks held.

Affected files ...

.. //depot/projects/smpng/sys/kern/kern_exit.c#95 edit
.. //depot/projects/smpng/sys/kern/kern_kse.c#20 edit

Differences ...

==== //depot/projects/smpng/sys/kern/kern_exit.c#95 (text+ko) ====

@@ -505,6 +505,8 @@
 	wakeup(p->p_pptr);
 	
 	PROC_UNLOCK(p->p_pptr);
+	WITNESS_WARN(WARN_PANIC, &p->p_mtx, "process (pid %d) exiting",
+	    p->p_pid);
 	mtx_lock_spin(&sched_lock);
 	critical_exit();
 

==== //depot/projects/smpng/sys/kern/kern_kse.c#20 (text+ko) ====

@@ -1304,7 +1304,7 @@
 		thread_export_context(td, 0);
 		/*
 		 * There is something to report, and we own an upcall
-		 * strucuture, we can go to userland.
+		 * structure, we can go to userland.
 		 * Turn ourself into an upcall thread.
 		 */
 		td->td_pflags |= TDP_UPCALLING;
@@ -1313,6 +1313,8 @@
 		PROC_LOCK(p);
 		if (kg->kg_upsleeps)
 			wakeup(&kg->kg_completed);
+		WITNESS_WARN(WARN_PANIC, &p->p_mtx,
+		    "thread exiting in userret");
 		mtx_lock_spin(&sched_lock);
 		thread_stopped(p);
 		thread_exit();