From owner-freebsd-stable@FreeBSD.ORG Wed Apr 2 11:16:53 2008 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8A4FC106566B; Wed, 2 Apr 2008 11:16:53 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from relay03.kiev.sovam.com (relay03.kiev.sovam.com [62.64.120.201]) by mx1.freebsd.org (Postfix) with ESMTP id 16E798FC23; Wed, 2 Apr 2008 11:16:52 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from [212.82.216.226] (helo=skuns.kiev.zoral.com.ua) by relay03.kiev.sovam.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.67) (envelope-from ) id 1Jh0xW-000AVv-4F; Wed, 02 Apr 2008 14:16:50 +0300 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by skuns.kiev.zoral.com.ua (8.14.2/8.14.2) with ESMTP id m32BGtvd073263 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 2 Apr 2008 14:16:56 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.2/8.14.2) with ESMTP id m32BGjJd022951; Wed, 2 Apr 2008 14:16:45 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.2/8.14.2/Submit) id m32BGj2b022950; Wed, 2 Apr 2008 14:16:45 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 2 Apr 2008 14:16:44 +0300 From: Kostik Belousov To: Vince Hoffman Message-ID: <20080402111644.GX21209@deviant.kiev.zoral.com.ua> References: <20080329222049.GA80263@eos.sc1.parodius.com> <47EED34E.2080400@unsane.co.uk> <47EFCF67.9040601@system.pl> <47F0A577.90800@unsane.co.uk> <20080331092035.GH21209@deviant.kiev.zoral.com.ua> <47F0C75B.9040000@unsane.co.uk> <20080331111714.GI21209@deviant.kiev.zoral.com.ua> <47F1F877.4010008@unsane.co.uk> <20080401094935.GQ21209@deviant.kiev.zoral.com.ua> <47F356EF.8040607@unsane.co.uk> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="c7rykKtsZvepKFKR" Content-Disposition: inline In-Reply-To: <47F356EF.8040607@unsane.co.uk> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: ClamAV version 0.91.2, clamav-milter version 0.91.2 on skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.4 X-Spam-Checker-Version: SpamAssassin 3.2.4 (2008-01-01) on skuns.kiev.zoral.com.ua X-Scanner-Signature: 9301293e34c22c108b5fa79baa05d543 X-DrWeb-checked: yes X-SpamTest-Envelope-From: kostikbel@gmail.com X-SpamTest-Group-ID: 00000000 X-SpamTest-Header: Not Detected X-SpamTest-Info: Profiles 2547 [Apr 02 2008] X-SpamTest-Info: helo_type=3 X-SpamTest-Method: none X-SpamTest-Rate: 0 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0278], KAS30/Release Cc: Marcin Cieslak , freebsd-stable@freebsd.org, freebsd-usb@freebsd.org Subject: Re: Panic with usb serial X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Apr 2008 11:16:53 -0000 --c7rykKtsZvepKFKR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 02, 2008 at 10:50:39AM +0100, Vince Hoffman wrote: > Kostik Belousov wrote: > > On Tue, Apr 01, 2008 at 09:55:19AM +0100, Vince Hoffman wrote: > >> Kostik Belousov wrote: > >>> On Mon, Mar 31, 2008 at 12:13:31PM +0100, Vince Hoffman wrote: > >>>> Kostik Belousov wrote: > >>> Compile the ddb into the kernel (instructions are provided at the same > >>> web page) and post the output of the console on the panic > >> I tried this but other than the fact I can drop into ddb and step thou= gh > >> stuff I'm not sure what I can do with it. Since I cant (obviously) get= a > >> serial console on my laptop I have done it the other way and taken a > >> picture of the console on panic. When I have more time I'll carry on > >> reading up on ddb but I think I have a steep learning curve since my > >> previous looks at programing stopped at 'hello world':) > >> Panic console at: > >> http://unsane.co.uk/~jhary/freebsd/IMAGE_119.jpg > >=20 > > Thanks, this is enough. Two chunks were missed from the rev. 1.210. > > Please, try the patch below. > >=20 > > diff --git a/sys/kern/kern_conf.c b/sys/kern/kern_conf.c > > index 843498e..7e6e048 100644 > > --- a/sys/kern/kern_conf.c > > +++ b/sys/kern/kern_conf.c > > @@ -402,8 +402,7 @@ giant_ioctl(struct cdev *dev, u_long cmd, caddr_t d= ata, int fflag, struct thread > > if (dsw =3D=3D NULL) > > return (ENXIO); > > mtx_lock(&Giant); > > - retval =3D dev->si_devsw->d_gianttrick-> > > - d_ioctl(dev, cmd, data, fflag, td); > > + retval =3D dsw->d_gianttrick->d_ioctl(dev, cmd, data, fflag, td); > > mtx_unlock(&Giant); > > dev_relthread(dev); > > return (retval); > > @@ -419,8 +418,7 @@ giant_read(struct cdev *dev, struct uio *uio, int i= oflag) > > if (dsw =3D=3D NULL) > > return (ENXIO); > > mtx_lock(&Giant); > > - retval =3D dev->si_devsw->d_gianttrick-> > > - d_read(dev, uio, ioflag); > > + retval =3D dsw->d_gianttrick->d_read(dev, uio, ioflag); > > mtx_unlock(&Giant); > > dev_relthread(dev); > > return (retval); >=20 > Hi Kostik, > Yes this stops the panic. I do still get the console spammed with > informational messages >=20 > Apr 2 10:36:30 prawn kernel: ucom0: 0/0, rev 1.10/4.00, addr 3> on uhub2 > Apr 2 10:36:33 prawn login: ROOT LOGIN (toor) ON ttyv0 > Apr 2 10:36:56 prawn kernel: ucom0: ucomreadcb: IOERROR > Apr 2 10:36:56 prawn kernel: ucom0: at uhub2 port 1 (addr 3) disconnected > Apr 2 10:36:57 prawn kernel: Still 4294967295 threads in ttyU0 > Apr 2 10:37:16 prawn last message repeated 188 times > Apr 2 10:37:16 prawn login: ROOT LOGIN (toor) ON ttyv1 > Apr 2 10:37:16 prawn kernel: Still 4294967295 threads in ttyU0 > Apr 2 10:37:47 prawn last message repeated 303 times > Apr 2 10:37:55 prawn last message repeated 85 times >=20 >=20 > but I can live with that. >=20 > I had opened PR usb/122287 for this, and I have updated this with the > relevent information from this thread. I committed the fix to the HEAD. I tested the patch with the uark(4) cable, and simply running the tip over the ttyU0 did not produced the "Still -1 threads in ttyU0" message. Are you running tip, or something else over the port ? --c7rykKtsZvepKFKR Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (FreeBSD) iEYEARECAAYFAkfzaxwACgkQC3+MBN1Mb4hi7wCfevuibsMCrgWt8C+e4Xmd7SIb v1wAoPbaEIc4Ts34yHrnac/vbIaknIgb =Mhhg -----END PGP SIGNATURE----- --c7rykKtsZvepKFKR--