From owner-freebsd-bugs@FreeBSD.ORG Sun Sep 12 17:40:27 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0369B16A4D1 for ; Sun, 12 Sep 2004 17:40:27 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id BFDC443D5F for ; Sun, 12 Sep 2004 17:40:26 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i8CHeQ8u009111 for ; Sun, 12 Sep 2004 17:40:26 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i8CHeQ4w009110; Sun, 12 Sep 2004 17:40:26 GMT (envelope-from gnats) Resent-Date: Sun, 12 Sep 2004 17:40:26 GMT Resent-Message-Id: <200409121740.i8CHeQ4w009110@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dan Lukes Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 50E0216A4CE for ; Sun, 12 Sep 2004 17:36:32 +0000 (GMT) Received: from kulesh.obluda.cz (kulesh.obluda.cz [193.179.22.243]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1873943D53 for ; Sun, 12 Sep 2004 17:36:31 +0000 (GMT) (envelope-from dan@obluda.cz) Received: from kulesh.obluda.cz (localhost.eunet.cz [127.0.0.1]) by kulesh.obluda.cz (8.13.1/8.13.1) with ESMTP id i8CHaTRp010916 for ; Sun, 12 Sep 2004 19:36:29 +0200 (CEST) (envelope-from dan@obluda.cz) Received: (from root@localhost) by kulesh.obluda.cz (8.13.1/8.13.1/Submit) id i8CHaSBp010915 for FreeBSD-gnats-submit@freebsd.org; Sun, 12 Sep 2004 19:36:28 +0200 (CEST) (envelope-from dan@obluda.cz) Message-Id: <200409121736.i8CHaSBp010915@kulesh.obluda.cz> Date: Sun, 12 Sep 2004 19:36:28 +0200 (CEST) From: Dan Lukes To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: bin/71667: [PATCH] cleanup of the usr.sbin/bootparamd code X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Dan Lukes List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Sep 2004 17:40:27 -0000 >Number: 71667 >Category: bin >Synopsis: [PATCH] cleanup of the usr.sbin/bootparamd code >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Sep 12 17:40:26 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Dan Lukes >Release: FreeBSD 5.3-BETA3 i386 >Organization: Obludarium >Environment: System: FreeBSD kulesh.obluda.cz 5.3-BETA3 FreeBSD 5.3-BETA3 #8: Sun Sep 5 07:06:40 CEST 2004 dan@kulesh.obluda.cz:/usr/obj/usr/src/sys/Dan i386 usr.sbin/bootparamd/callbootd/callbootd.c,v 1.10 2003/06/20 04:54:27 jmg include/rpcsvc/bootparam_prot.x,v 1.7 2003/05/04 02:51:42 obrien >Description: There are more than 5000 warnings issued during "make buildworld". Some of them are false positives, but some of them are sign of true errors. Nobody is upset by warnings due it's amount, so some errors remain uncorrected. I want to cleanup the code-base from warnings, so warnings will become "attention mark" again. usr.sbin/bootparamd/callbootd/callbootd.c:83: warning: 'clnt' might be used uninitialized in this function bootparam_prot_clnt.c:24: warning: implicit declaration of function `memset' >How-To-Repeat: N/A >Fix: *** usr.sbin/bootparamd/callbootd/callbootd.c.ORIG Tue Jul 15 22:47:06 2003 --- usr.sbin/bootparamd/callbootd/callbootd.c Sun Sep 12 16:24:45 2004 *************** *** 80,86 **** long the_inet_addr; ! CLIENT *clnt; enum clnt_stat clnt_stat; stat_whoami_res.client_name = cln; --- 80,86 ---- long the_inet_addr; ! CLIENT *clnt = clnt; /* "init" to avoid "might be used uninitialized" warning */ enum clnt_stat clnt_stat; stat_whoami_res.client_name = cln; *** usr.sbin/bootparamd/../../include/rpcsvc/bootparam_prot.x.ORIG Thu May 29 19:24:23 2003 --- usr.sbin/bootparamd/../../include/rpcsvc/bootparam_prot.x Sun Sep 12 16:27:51 2004 *************** *** 39,44 **** --- 39,45 ---- #ifdef RPC_HDR %#include + %#include %#include %#include %#include >Release-Note: >Audit-Trail: >Unformatted: