From owner-svn-src-head@FreeBSD.ORG Tue Nov 20 07:15:45 2012 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4B7127E1; Tue, 20 Nov 2012 07:15:45 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (gatekeeper.allbsd.org [IPv6:2001:2f0:104:e001::32]) by mx1.freebsd.org (Postfix) with ESMTP id 6EE0B8FC15; Tue, 20 Nov 2012 07:15:42 +0000 (UTC) Received: from alph.allbsd.org (p1137-ipbf1505funabasi.chiba.ocn.ne.jp [118.7.212.137]) (authenticated bits=128) by mail.allbsd.org (8.14.5/8.14.5) with ESMTP id qAK7FDr4041985 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 20 Nov 2012 16:15:28 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) (authenticated bits=0) by alph.allbsd.org (8.14.5/8.14.5) with ESMTP id qAK7FBo8044342; Tue, 20 Nov 2012 16:15:12 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Tue, 20 Nov 2012 16:14:34 +0900 (JST) Message-Id: <20121120.161434.1928803376818060657.hrs@allbsd.org> To: mike.telahun@gmail.com Subject: Re: svn commit: r243324 - head/etc From: Hiroki Sato In-Reply-To: <50AB19D3.9080106@gmail.com> References: <201211200445.qAK4j4YF027280@svn.freebsd.org> <50AB19D3.9080106@gmail.com> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.5 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Tue_Nov_20_16_14_34_2012_620)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.97.4 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (mail.allbsd.org [133.31.130.32]); Tue, 20 Nov 2012 16:15:30 +0900 (JST) X-Spam-Status: No, score=-98.1 required=13.0 tests=CONTENT_TYPE_PRESENT, ONLY1HOPDIRECT,SAMEHELOBY2HOP,USER_IN_WHITELIST autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on gatekeeper.allbsd.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2012 07:15:45 -0000 ----Security_Multipart(Tue_Nov_20_16_14_34_2012_620)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mike Telahun wrote in <50AB19D3.9080106@gmail.com>: mi> > @@ -704,7 +704,10 @@ run_rc_command() mi> > mi> > start) mi> > if [ -z "$rc_fast" -a -n "$rc_pid" ]; then mi> > - echo 1>&2 "${name} already running? (pid=$rc_pid)." mi> > + if [ -z "$rc_quiet" ]; then mi> mi> Shouldn't this be using checkyesno() ? mi> What happens if someone has rc_quiet=NO in /etc/rc.conf? rc_fast, rc_force, and rc_quiet are not intended to be used in /etc/rc.conf or other config files. These variables have no default value and will be defined forcibly via {fast,force,quiet}start. If we use checkyesno() here, it checks whether a variable is defined or not and then put an warning message when not defined. It is a bad side-effect for them. -- Hiroki ----Security_Multipart(Tue_Nov_20_16_14_34_2012_620)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEABECAAYFAlCrLdoACgkQTyzT2CeTzy2RDwCfZBTwX8TUMmtEBr4s4x/1lIHy qEoAoM38y7nb6eihI8rwZJOW2R7GOXhH =4HCO -----END PGP SIGNATURE----- ----Security_Multipart(Tue_Nov_20_16_14_34_2012_620)----