From owner-svn-ports-all@freebsd.org Fri Apr 13 10:07:37 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 18A71FA11FB; Fri, 13 Apr 2018 10:07:37 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BC1A171081; Fri, 13 Apr 2018 10:07:36 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id B3954F32B; Fri, 13 Apr 2018 10:07:36 +0000 (UTC) Date: Fri, 13 Apr 2018 10:07:36 +0000 From: Alexey Dokuchaev To: Matthias Fechner Cc: Sunpoet Po-Chuan Hsieh , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r467193 - in head/www/gitlab: . files Message-ID: <20180413100736.GA32041@FreeBSD.org> References: <201804121833.w3CIXtgW077267@repo.freebsd.org> <431aaec9-51c2-c0c9-7a1f-2f29f79edb5d@fechner.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <431aaec9-51c2-c0c9-7a1f-2f29f79edb5d@fechner.net> User-Agent: Mutt/1.9.2 (2017-12-15) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Apr 2018 10:07:37 -0000 On Fri, Apr 13, 2018 at 11:55:13AM +0200, Matthias Fechner wrote: > ... > To make tests for all features in Gitlab you will require many hours and > I'm not willing to do the work the gitlab team is doing already for us. > They provide us with clear instructions what version are tested and > should work. > To be 100% save we should use what is in the Gemfile.lock, but this > would really a major effort and I think to use what is in Gemfile > defined is relatively safe. > I remember only 2 cases where even the definition in the Gemfiles cause > gitlab to break. One was the upgrade of default_value_for from 3.0.3 to > 3.0.4. I don't quite understand how/why would anyone in their right mind write software than breaks when one of its dependencies have *minor* version bump? Is this specific to Gitlab, or the nature of Gemfiles is really that broken? ./danfe