From owner-svn-src-all@FreeBSD.ORG Tue May 8 05:11:22 2012 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id CEF1C1065670; Tue, 8 May 2012 05:11:22 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 81A688FC18; Tue, 8 May 2012 05:11:21 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id IAA12269; Tue, 08 May 2012 08:11:20 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1SRchj-000K3g-Ue; Tue, 08 May 2012 08:11:19 +0300 Message-ID: <4FA8AAF7.50107@FreeBSD.org> Date: Tue, 08 May 2012 08:11:19 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:12.0) Gecko/20120503 Thunderbird/12.0.1 MIME-Version: 1.0 To: Pawel Jakub Dawidek References: <201205071503.q47F3gsa070124@svn.freebsd.org> <20120508020119.GE1395@garage.freebsd.pl> In-Reply-To: <20120508020119.GE1395@garage.freebsd.pl> X-Enigmail-Version: 1.5pre Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r235129 - head/tools/tools/zfsboottest X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 May 2012 05:11:22 -0000 on 08/05/2012 05:01 Pawel Jakub Dawidek said the following: > On Mon, May 07, 2012 at 03:03:42PM +0000, Andriy Gapon wrote: >> Author: avg >> Date: Mon May 7 15:03:42 2012 >> New Revision: 235129 >> URL: http://svn.freebsd.org/changeset/base/235129 >> >> Log: >> zfsboottest.sh: gracefully handle default value of bootfs property > > I'd prefer if people avoid having their root file system at the pool > level, so maybe we could leave it as a warning? I see reasons to have this preference, I am just not sure that _this_ tool should be used to annoy people by telling them that their preference is inferior. I think that the various ZFS setup guides and howtos (including those by you) should already provide good examples. So if somebody doesn't follow them to the letter, then he is probably confident of his ZFS mastery. >> Reported by: theraven >> MFC after: 10 days >> >> Modified: >> head/tools/tools/zfsboottest/zfsboottest.sh >> >> Modified: head/tools/tools/zfsboottest/zfsboottest.sh >> ============================================================================== >> --- head/tools/tools/zfsboottest/zfsboottest.sh Mon May 7 14:07:13 2012 (r235128) >> +++ head/tools/tools/zfsboottest/zfsboottest.sh Mon May 7 15:03:42 2012 (r235129) >> @@ -52,8 +52,7 @@ if [ $? -ne 0 ]; then >> fi >> bootfs=`zpool get bootfs "${pool}" | tail -1 | awk '{print $3}'` >> if [ "${bootfs}" = "-" ]; then >> - echo "The \"bootfs\" property is not configured for pool \"${pool}\"." >&2 >> - exit 1 >> + bootfs="${pool}" >> fi >> # Dataset's mountpoint property should be set to 'legacy'. >> if [ "`zfs get -H -o value mountpoint ${bootfs}`" != "legacy" ]; then > -- Andriy Gapon