From owner-freebsd-net@FreeBSD.ORG  Fri Apr 20 17:43:18 2007
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
X-Original-To: freebsd-net@freebsd.org
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id DBA9F16A414
	for <freebsd-net@freebsd.org>; Fri, 20 Apr 2007 17:43:18 +0000 (UTC)
	(envelope-from rizzo@icir.org)
Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68])
	by mx1.freebsd.org (Postfix) with ESMTP id 9F2A613C4DE
	for <freebsd-net@freebsd.org>; Fri, 20 Apr 2007 17:43:18 +0000 (UTC)
	(envelope-from rizzo@icir.org)
Received: from xorpc.icir.org (localhost [127.0.0.1])
	by xorpc.icir.org (8.12.11/8.13.6) with ESMTP id l3KHhI9c067847;
	Fri, 20 Apr 2007 10:43:18 -0700 (PDT)
	(envelope-from rizzo@xorpc.icir.org)
Received: (from rizzo@localhost)
	by xorpc.icir.org (8.12.11/8.12.3/Submit) id l3KHhIrP067846;
	Fri, 20 Apr 2007 10:43:18 -0700 (PDT) (envelope-from rizzo)
Date: Fri, 20 Apr 2007 10:43:18 -0700
From: Luigi Rizzo <rizzo@icir.org>
To: Bruce M Simpson <bms@incunabulum.net>
Message-ID: <20070420104318.A67833@xorpc.icir.org>
References: <4628DA3A.3050309@incunabulum.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <4628DA3A.3050309@incunabulum.net>;
	from bms@incunabulum.net on Fri, Apr 20, 2007 at 04:20:26PM +0100
Cc: FreeBSD-Net mailing list <freebsd-net@freebsd.org>
Subject: Re: MFC of ether_input() changes
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Apr 2007 17:43:18 -0000

On Fri, Apr 20, 2007 at 04:20:26PM +0100, Bruce M Simpson wrote:
> Hi,
> 
> Does anyone want to see these changes MFCed, or otherwise object to such 
> an MFC?
> The introduction of M_PROMISC did the following:
> 
>    * Drop frames immediately if the interface is not marked IFF_UP.
>    * Always trim off the frame checksum if present.
>    * Always use M_VLANTAG in preference to passing 802.1Q frames
>      to consumers.
>    * Use __func__ consistently for KASSERT().
>    * Use the M_PROMISC flag to detect situations where ether_input()
>      may reenter itself on the same call graph with the same mbuf which
>      was promiscuously received on behalf of subsystems such as
>      netgraph, carp, and vlan.
>    * 802.1P frames (that is, VLAN frames with an ID of 0) will now be
>      passed to layer 3 input paths.
>    * Deal with the special case for CARP in a sane way.
> 
> For end users the main change of interest will be the ability for 
> FreeBSD to receive 802.1p frames, even if it doesn't do anything with 
> the priority fields right now.
> 
> If I hear 'yeses' I will try to MFC this as time permits.

yes please!

luigi