From owner-freebsd-acpi@FreeBSD.ORG Tue Feb 19 14:38:51 2008 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0EFC316A418 for ; Tue, 19 Feb 2008 14:38:51 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: from fk-out-0910.google.com (fk-out-0910.google.com [209.85.128.187]) by mx1.freebsd.org (Postfix) with ESMTP id 8A12013C45D for ; Tue, 19 Feb 2008 14:38:50 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: by fk-out-0910.google.com with SMTP id b27so2517909fka.11 for ; Tue, 19 Feb 2008 06:38:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:cc:message-id:from:to:in-reply-to:content-type:content-transfer-encoding:mime-version:subject:date:references:x-mailer:sender; bh=6tNYa+MPIY1WwkE2d0DZcuu2AqOQjEzmP7UK1Y62jAU=; b=dJxZrNfWmN1Ytoaw4q7KYcEDL31QAK7jSuBwmFxi9xSLtT3lRuwqzYFzEzUGgEOACW2rqiWGBb56IzsbTlZ9vraO7m0vi0BKuBkZBeCi6D3qI6Dp4qwn35rnzxWXKegIKGg+KM7qG+UtQQHq8LlKv6u1u6phW7buDAicJ0GFCmw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=cc:message-id:from:to:in-reply-to:content-type:content-transfer-encoding:mime-version:subject:date:references:x-mailer:sender; b=Own0R6SZWtEpH6FX2a49yR7vVOO7Dkuh8N+Y91pkZ6fjSBvUiXmv47tC2c7B4iNS3oFGSbVE5Av8J67evQzxbWGdZ77lMdzgvbt6X0lqRn9eXn7FVK7NTnBDzaqhjiObW/mqCjkiv617Uhg1GZHAWLEZNb05zMiWwdSObBXNn24= Received: by 10.82.127.14 with SMTP id z14mr12658844buc.26.1203431925956; Tue, 19 Feb 2008 06:38:45 -0800 (PST) Received: from ?172.17.7.212? ( [193.136.24.128]) by mx.google.com with ESMTPS id g11sm8405530gve.6.2008.02.19.06.38.44 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 19 Feb 2008 06:38:45 -0800 (PST) Message-Id: <98F7E48C-1CBF-494D-8411-D80E25247214@FreeBSD.org> From: Rui Paulo To: Andriy Gapon In-Reply-To: <47B96989.6070008@icyb.net.ua> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v919.2) Date: Mon, 18 Feb 2008 23:00:52 +0000 References: <47B96989.6070008@icyb.net.ua> X-Mailer: Apple Mail (2.919.2) Sender: Rui Paulo Cc: freebsd-acpi@freebsd.org Subject: Re: acpi_throttle: quirk based on pci info X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Feb 2008 14:38:51 -0000 On Feb 18, 2008, at 11:18 AM, Andriy Gapon wrote: > > While looking for something else I accidentally noticed that > acpi_throttle has one quirk for some early revisions of PIIX4 chipset > and the quirk is enabled based on PCI info. > I have a newer revision of PIIX4 so the quirk is not applicable in > my case. > > Nevertheless I noticed that acpi_throttle is initialized before PCI > bus > driver, so when it calls pci_find_device() it always returns NULL and > quirk is not applied. At least this is what I see in dmesg on my > machine. I run into a similar problem on my SoC MacBook project and I ended up using the SMI vendor strings because it was too early in boot in order to find the PCI devices. The problem here is very similar. Maybe we should try to use SMI vendor strings instead of pci_find_device()? Regards. -- Rui Paulo