Date: Sat, 21 Dec 2013 22:58:11 -0800 From: Stanislav Sedov <stas@freebsd.org> To: Warner Losh <imp@bsdimp.com> Cc: "freebsd-arm@freebsd.org" <arm@FreeBSD.org> Subject: Re: 10.0-release proposed patch for Atmel Message-ID: <AAA12087-1CE8-4B55-9CEB-2F9DD55A93FF@freebsd.org> In-Reply-To: <B5B10EE3-955D-4A8C-A233-9DADF6898A54@bsdimp.com> References: <B5B10EE3-955D-4A8C-A233-9DADF6898A54@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Dec 21, 2013, at 10:44 PM, Warner Losh <imp@bsdimp.com> wrote: > Gentlemen, >=20 > Right now, the mountroot prompt doesn't work on Atmel CPUs. Almost all = the characters are eaten. I recently committed an elegant fix for this = into head to mask the interrupt for new characters and only do polling. >=20 > However, it touched the base uart. In an abundance of caution, the re@ = has asked me to see if I can come up with a fix w/o that. >=20 > A less elegant, less functional fix can be found at = http://people.freebsd.org/~imp/at91-mountroot-10.diff >=20 > This fix defers turning on the RXRDY bit in the interrupt mask until = we get the first interrupt after the first opening of the device. This = is sufficient for mountroot> to work, but wouldn't fix things like GELI = that prompt the user from the kernel. I think that's acceptable for 10.0 = given the typical use case for atmel. >=20 > Can the folks here that know Atmel take a look at the patch and let me = know what you think? >=20 Looks correct to me. This is probably the safest way to go and will = solve the issue for the majority of use cases as you said. Thanks! -- ST4096-RIPE
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AAA12087-1CE8-4B55-9CEB-2F9DD55A93FF>