From owner-freebsd-bugs Mon Jun 11 20:40: 8 2001 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 9897837B401 for ; Mon, 11 Jun 2001 20:40:06 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.11.3/8.11.3) id f5C3e6Y90202; Mon, 11 Jun 2001 20:40:06 -0700 (PDT) (envelope-from gnats) Date: Mon, 11 Jun 2001 20:40:06 -0700 (PDT) Message-Id: <200106120340.f5C3e6Y90202@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Dima Dorfman Subject: Re: bin/28082: [patch] src/usr.bin/whois clean-up Reply-To: Dima Dorfman Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org The following reply was made to PR bin/28082; it has been noted by GNATS. From: Dima Dorfman To: mike@q9media.com Cc: FreeBSD-gnats-submit@freebsd.org Subject: Re: bin/28082: [patch] src/usr.bin/whois clean-up Date: Mon, 11 Jun 2001 20:38:19 -0700 mike@q9media.com writes: >Description: > > The following patch has been sent to -audit. Reviewed by mikeh and gad. > All problems brought up were resolved. > > > 20010605 whois.patch > > o Silence warnings and set WARNS=2 > o Fix two memory leaks > o asprint -> strdup where appropriate > o calloc/strcpy/strcat -> aprintf > o Convert to ANSI C to avoid having to prototype main() I don't think this is a good reason to ANSIify something, especially since gcc no longer complains about that. Dima Dorfman dima@unixfreak.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message