Date: Tue, 10 Jul 2012 15:41:28 +0200 From: Fabian Keil <freebsd-listen@fabiankeil.de> To: Andriy Gapon <avg@FreeBSD.org> Cc: freebsd-hackers@FreeBSD.org, Sean Bruno <sbruno@FreeBSD.org>, rmacklem@FreeBSD.org Subject: Re: dtraceall.ko with old nfsclient Message-ID: <20120710154128.192eb8d6@fabiankeil.de> In-Reply-To: <4FFB4770.7050209@FreeBSD.org> References: <1341863341.6064.11.camel@powernoodle.corp.yahoo.com> <4FFB4770.7050209@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_/iioYr4df0X.XEcWMnzauWlK Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Andriy Gapon <avg@FreeBSD.org> wrote: > on 09/07/2012 22:49 Sean Bruno said the following: > > Ran into some symbol errors with the dtraceall module when using the > > *old* nfs client. > >=20 > > I think that this is more or less the right thing to do, but I'm not > > sure. > >=20 > > --- //depot/yahoo/ybsd_9/src/sys/modules/dtrace/dtraceall/dtraceall.c > > 2011-11-02 23:46:55.000000000 0000 > > +++ /home/seanbru/dtrace_9/src/sys/modules/dtrace/dtraceall/dtraceall.c > > 2011-11-02 23:46:55.000000000 0000 > > @@ -66,8 +66,11 @@ > > MODULE_DEPEND(dtraceall, opensolaris, 1, 1, 1); > > MODULE_DEPEND(dtraceall, dtrace, 1, 1, 1); > > MODULE_DEPEND(dtraceall, dtmalloc, 1, 1, 1); > > +#if defined (NFSCL) > > MODULE_DEPEND(dtraceall, dtnfscl, 1, 1, 1); > > +#else /* defined (NFSCLIENT) */ Any objections to changing this to #elif defined (NFSCLIENT) ? > > MODULE_DEPEND(dtraceall, dtnfsclient, 1, 1, 1); > > +#endif > > #if defined(__amd64__) || defined(__i386__) > > MODULE_DEPEND(dtraceall, fbt, 1, 1, 1); > > MODULE_DEPEND(dtraceall, fasttrap, 1, 1, 1); >=20 > Just to add some noise to the signal - my personal opinion is that nfs su= pport > doesn't have to be in dtraceall. Maybe in something "all-er" :-) I have no opinion on whether or not dtraceall should depend on nfs modules if they are available, but I would prefer it if the dependency was optional. I do not use any nfs modules and the hard-coded dependency made dtraceall useless for me in the past. Unlike Sean I worked around it with a shell function and was too lazy to investigate the cause, though. Fabian --Sig_/iioYr4df0X.XEcWMnzauWlK Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAk/8MQsACgkQBYqIVf93VJ1aoACfXUiqn2FDfrnaOwz1/OxGaw47 8CUAnAoLGJwMPVV0nhcjZWp/q4JpG+XK =a/qv -----END PGP SIGNATURE----- --Sig_/iioYr4df0X.XEcWMnzauWlK--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120710154128.192eb8d6>