From owner-svn-src-all@FreeBSD.ORG Tue Jun 3 01:29:46 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 755B5E07; Tue, 3 Jun 2014 01:29:46 +0000 (UTC) Received: from mail-pb0-x231.google.com (mail-pb0-x231.google.com [IPv6:2607:f8b0:400e:c01::231]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2FE9929C3; Tue, 3 Jun 2014 01:29:46 +0000 (UTC) Received: by mail-pb0-f49.google.com with SMTP id jt11so4798926pbb.22 for ; Mon, 02 Jun 2014 18:29:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=ccOdxafiN2thqgxSYpIVvC2m/ttKpuuTs9cK17g6T3M=; b=nTWXvX3tw6FmRJHDq0HMXR/wFshn6TyoYZNeauIekpU5IjgqHOss0dgZ+jwl90h+ZT Ael0WW1rCp5PVwVcx+tBvAoFiIvIn9QJbU9m4H1fACODwYVQ5l7aG2Z0N1d56oQcuKm4 F9P3WJHSRQg2bo9f+XhIaQLK84XCzAnkjAxYUHeLt8n3Su226ewBrUqhyZ7ETXVgPW/f gMOujl3GxDpVb3zrorUfwKGmmeuXdeHiJmKjsfsvH3hLa9Y9VK8rfNLSknDovdO9YBMM yORfEhvK7IAZ8vKgZ/rH8yNqxMpGHoTsZ1atkD3YMZ++aVBTu33ejzqY1JojjIXAFQ/2 JV5A== X-Received: by 10.69.31.202 with SMTP id ko10mr40323878pbd.23.1401758985824; Mon, 02 Jun 2014 18:29:45 -0700 (PDT) Received: from pyunyh@gmail.com (lpe4.p59-icn.cdngp.net. [114.111.62.249]) by mx.google.com with ESMTPSA id io6sm71374717pac.44.2014.06.02.18.29.42 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 02 Jun 2014 18:29:45 -0700 (PDT) From: Yonghyeon PYUN X-Google-Original-From: "Yonghyeon PYUN" Received: by pyunyh@gmail.com (sSMTP sendmail emulation); Tue, 03 Jun 2014 10:29:39 +0900 Date: Tue, 3 Jun 2014 10:29:39 +0900 To: Marcel Moolenaar Subject: Re: svn commit: r266974 - in head/sys: dev/dc dev/fxp dev/mii dev/netmap kern net Message-ID: <20140603012939.GA2998@michelle.cdnetworks.com> Reply-To: pyunyh@gmail.com References: <201406021754.s52Hsd1B039620@svn.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i Cc: "svn-src-head@freebsd.org" , Adrian Chadd , Marcel Moolenaar , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jun 2014 01:29:46 -0000 On Mon, Jun 02, 2014 at 11:42:10AM -0700, Marcel Moolenaar wrote: > > On Jun 2, 2014, at 11:27 AM, Adrian Chadd wrote: > > > .. and actually, bikeshedding for a moment, would we be able to move a > > lot of these accessor methods over to inlines? Would that break the > > Juniper way of doing things? > > That would definitely break Juniper as it doesn't give a stable > ABI. > > I've suggested an approach that allows for both, but it was deemed > unnecessary. The argument being that the function call overhead is > negligible. > > We can always revisit that decision if needed... > The function call overheads shall show measurable differences on slow boxes. This change adds several function calls in driver's fast path(interrupt handler, packet statistics, checksum offloading checking and etc) and these functions would be called on every TX/RX packet. It would be great if there is a way to minimize function call overheads in fast path.