Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 16 Aug 2011 10:52:29 +0000 (UTC)
From:      Alexander Motin <mav@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org
Subject:   svn commit: r224908 - stable/8/sys/dev/usb
Message-ID:  <201108161052.p7GAqTvK054835@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mav
Date: Tue Aug 16 10:52:29 2011
New Revision: 224908
URL: http://svn.freebsd.org/changeset/base/224908

Log:
  MFC r224728:
  Do not block zero report ID. It is correct value for devices with single
  ID. This fixes USB_SET_IMMED call (synchronous operation) of the uhid(4)
  driver on devices with single report ID.

Modified:
  stable/8/sys/dev/usb/usb_request.c
Directory Properties:
  stable/8/sys/   (props changed)
  stable/8/sys/amd64/include/xen/   (props changed)
  stable/8/sys/cddl/contrib/opensolaris/   (props changed)
  stable/8/sys/contrib/dev/acpica/   (props changed)
  stable/8/sys/contrib/pf/   (props changed)

Modified: stable/8/sys/dev/usb/usb_request.c
==============================================================================
--- stable/8/sys/dev/usb/usb_request.c	Tue Aug 16 09:07:59 2011	(r224907)
+++ stable/8/sys/dev/usb/usb_request.c	Tue Aug 16 10:52:29 2011	(r224908)
@@ -1769,7 +1769,7 @@ usbd_req_get_report(struct usb_device *u
 	struct usb_interface *iface = usbd_get_iface(udev, iface_index);
 	struct usb_device_request req;
 
-	if ((iface == NULL) || (iface->idesc == NULL) || (id == 0)) {
+	if ((iface == NULL) || (iface->idesc == NULL)) {
 		return (USB_ERR_INVAL);
 	}
 	DPRINTFN(5, "len=%d\n", len);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201108161052.p7GAqTvK054835>