From owner-svn-src-head@FreeBSD.ORG Fri Mar 14 09:32:05 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DE531742; Fri, 14 Mar 2014 09:32:05 +0000 (UTC) Received: from mta04.bitpro.no (mta04.bitpro.no [92.42.64.203]) by mx1.freebsd.org (Postfix) with ESMTP id 96CEBD61; Fri, 14 Mar 2014 09:32:05 +0000 (UTC) Received: from mail.lockless.no (mail.lockless.no [46.29.221.38]) by mta04.bitpro.no (Postfix) with ESMTPS id 7105410021A; Fri, 14 Mar 2014 10:32:03 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail.lockless.no (Postfix) with ESMTP id 110008F8B13; Fri, 14 Mar 2014 10:31:57 +0100 (CET) X-Virus-Scanned: by amavisd-new-2.6.4 (20090625) (Debian) at lockless.no Received: from mail.lockless.no ([127.0.0.1]) by localhost (mail.lockless.no [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VpadQNjxwUqu; Fri, 14 Mar 2014 10:31:56 +0100 (CET) Received: from laptop015.home.selasky.org (cm-176.74.213.204.customer.telag.net [176.74.213.204]) by mail.lockless.no (Postfix) with ESMTPSA id CB23E8F8A9B; Fri, 14 Mar 2014 10:31:56 +0100 (CET) Message-ID: <5322CCC5.7020608@bitfrost.no> Date: Fri, 14 Mar 2014 10:32:53 +0100 From: Hans Petter Selasky User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Rui Paulo Subject: Re: svn commit: r262972 - head/sys/dev/usb/input References: <201403100852.s2A8qUdC045704@svn.freebsd.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Mar 2014 09:32:05 -0000 On 03/14/14 03:15, Rui Paulo wrote: > On 10 Mar 2014, at 01:52, Hans Petter Selasky wrote: > >> Author: hselasky >> Date: Mon Mar 10 08:52:30 2014 >> New Revision: 262972 >> URL: http://svnweb.freebsd.org/changeset/base/262972 >> >> Log: >> Ignore USB keyboard driver calls from critical sections. >> >> Reported by: Oliver Pinter >> MFC after: 1 week >> >> Modified: >> head/sys/dev/usb/input/ukbd.c >> >> Modified: head/sys/dev/usb/input/ukbd.c >> ============================================================================== >> --- head/sys/dev/usb/input/ukbd.c Mon Mar 10 06:41:48 2014 (r262971) >> +++ head/sys/dev/usb/input/ukbd.c Mon Mar 10 08:52:30 2014 (r262972) >> @@ -1909,6 +1909,12 @@ ukbd_ioctl(keyboard_t *kbd, u_long cmd, >> int result; >> >> /* >> + * XXX Check of someone is calling us from a critical section: >> + */ >> + if (curthread->td_critnest != 0) >> + return (EDEADLK); > > Shouldn't this panic? > > -- > Rui Paulo > Hi, This happens on shutdown, in some special case. Not sure if panic at shutdown is appropriate? --HPS