From owner-freebsd-virtualization@FreeBSD.ORG  Mon Jun  9 19:47:12 2008
Return-Path: <owner-freebsd-virtualization@FreeBSD.ORG>
Delivered-To: freebsd-virtualization@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A5673106567D
	for <freebsd-virtualization@freebsd.org>;
	Mon,  9 Jun 2008 19:47:12 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from outU.internet-mail-service.net (outu.internet-mail-service.net
	[216.240.47.244])
	by mx1.freebsd.org (Postfix) with ESMTP id 93F288FC1C
	for <freebsd-virtualization@freebsd.org>;
	Mon,  9 Jun 2008 19:47:12 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from idiom.com (mx0.idiom.com [216.240.32.160])
	by out.internet-mail-service.net (Postfix) with ESMTP id 863422425;
	Mon,  9 Jun 2008 12:47:12 -0700 (PDT)
Received: from julian-mac.elischer.org (localhost [127.0.0.1])
	by idiom.com (Postfix) with ESMTP id 918FC2D623F;
	Mon,  9 Jun 2008 12:46:58 -0700 (PDT)
Message-ID: <484D88AC.2000402@elischer.org>
Date: Mon, 09 Jun 2008 12:46:52 -0700
From: Julian Elischer <julian@elischer.org>
User-Agent: Thunderbird 2.0.0.14 (Macintosh/20080421)
MIME-Version: 1.0
To: FreeBSD Net <freebsd-net@freebsd.org>, freebsd-virtualization@freebsd.org
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: 
Subject: vimage include files
X-BeenThere: freebsd-virtualization@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Discussion of various virtualization techniques FreeBSD supports."
	<freebsd-virtualization.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-virtualization>,
	<mailto:freebsd-virtualization-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-virtualization>
List-Post: <mailto:freebsd-virtualization@freebsd.org>
List-Help: <mailto:freebsd-virtualization-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-virtualization>,
	<mailto:freebsd-virtualization-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Jun 2008 19:47:12 -0000

The current vimage code adds a handful of new include files..
e.g.

vnet.h for vimage related defines that are related to general 
networking stuff

vinet for vimage related defines that are related to inet.

however eventually these defines would move to other files.

For example I think every single file that includes vinet.h
already includes netinet/in.h
so these definitions move into that file.

My question however comes with vnet.h

95% of the files that use it also include <net/if.h>
so possibly they could go there,
but a few of them don't.

they are:
uipc_socket.c      (sets a reference counter in the vnet structure)
raw_cb.c           accesses V_rawcb_list
raw_usrreq.c       accesses V_rawcb_list
tcp_output.c       lots of stuff of course but doesn't use if.h
tcp_timer.c        ditto
                    vnet appears to be needed jsut for the SYSCTL_V_
                    stuff. (marko?)

netipsec/keysock.c  no need for if.h

so there is no one place where all of the vnet structure is in scope
but if.h is the closest.


so should we:
keep vnet.h?
split it up a bit to make it more in scope?
Find/make an include file for "networking in general?"

is there such a file? As I said if.h seems the closest.