From nobody Tue May 12 16:44:44 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gFMrX2r9Xz6ckMY for ; Tue, 12 May 2026 16:44:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gFMrX2BVbz3swS for ; Tue, 12 May 2026 16:44:44 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1778604284; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eVS0UlS/z9GXBqi/dxtCUkoPzGw7oNLyecGFOB/bYC4=; b=rbourm8y43IJ+vFO7omDP1OhcIHbPpuspkaFC+6T46ctqpEzMUm6bVMGUGTfUguvy4C6yK 238r/pNyzBeWlDWfBv8vLrdGU3L8N+SquDdTsCNY7r0BspBJwqCQv0/aMsWyPTtKhYMT2e rGL6JYq4xFpkHfUbcaJlveA//icpGRJSa1OYd5Cs7jFEOQj3s/tfD6E/ptJNK8HopALDpJ 4c7b/G4HH2Wc7k5mZyZHilNAn7+QSehd/2idKR0I54ObCLWJ77Czj5mAb+3IKsIfCAzAdh ihMR8lM2Peu4n8a/K4lCkonETpPiVGLUk2eB3E2GcucynXqru2x8wM2jjklQ6g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1778604284; a=rsa-sha256; cv=none; b=A9T6AGWLIVva+wuO4SAgEzEw4kb3C0khQdBwSKE/4YNi7H8exA+ScyypqMUMeBDk3kmyRG 8/cZ+Y6wKxcDlFuKE0NCXm9MgOrvh14knVViD46tQlULtQjkQGQ/hej7jFYeROi9mllePL 1mQsSyCyb4k7QKO7sE85SnpnXeB0qjTVv+8+E4dH/TftE3ctjQ7oO85YPeRpb9vdBQNHjE Kvw9mXXnqC21I3P9S/pMV78EitH6hBvKwEEwYgFK6CCyqxAPcU9UidzEg1lg+ChbGM4ZzV pr5bmwLQwMrQPjeBjbZBBRdevPF+hDl+2U5YKjsXfH0mTR+VJfTPgIp+Cf/4jg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1778604284; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eVS0UlS/z9GXBqi/dxtCUkoPzGw7oNLyecGFOB/bYC4=; b=JbIj5PGO2ztCI0IFQx2adCXMIJXoL6U+UG5X/osY+By94MOGw9Lppbs0/rLPAJiSFvJ2Zs 2qHaiiEpO2bIC9qWlOdRthUlnNZZtqHWbDxjAdl94TRLak4K8JgnTj2DbRYv+/AFnqzYIv K19MLEQXs2+QGea2mRnsocE1uH3i25ksz8SzwLoGVKnv2q+K3Uopmd2UwaDfOGLfdgl8Vd MOt4hLURqKdX3vfoMTItKEmzH1Zo7Wjd509gEvY4doDPgziGDr/diyOEujke9cXBs4G5Ni o2YBDZA9eA+TDNsda48rwKULLIEpXwel9bvAHgX8WnoBbGVdsg2uP1pKXnSwPQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gFMrX1ljhz19kt for ; Tue, 12 May 2026 16:44:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3ce12 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 12 May 2026 16:44:44 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kristof Provost Subject: git: 8d583858e499 - stable/14 - pfsync: reject invalid SCTP states List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 8d583858e499dcc23a1c7b6b9c80e2e84f245d04 Auto-Submitted: auto-generated Date: Tue, 12 May 2026 16:44:44 +0000 Message-Id: <6a0358fc.3ce12.672d0d5a@gitrepo.freebsd.org> The branch stable/14 has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=8d583858e499dcc23a1c7b6b9c80e2e84f245d04 commit 8d583858e499dcc23a1c7b6b9c80e2e84f245d04 Author: Kristof Provost AuthorDate: 2026-05-04 16:08:35 +0000 Commit: Kristof Provost CommitDate: 2026-05-12 07:54:38 +0000 pfsync: reject invalid SCTP states SCTP states should always have a src scrub object associated with them. Crafted pfsync packets might not have this, leading to us derferencing a NULL pointer on cleanup. Validate the pfsync state insertion packet to make sure this is correct. PR: 294989 MFC after: 1 week Sponsored by: Rubicon Communications, LLC ("Netgate") (cherry picked from commit bf6d00afdb6171ba04a1c5a7fde904cde87d212d) --- sys/netpfil/pf/if_pfsync.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sys/netpfil/pf/if_pfsync.c b/sys/netpfil/pf/if_pfsync.c index 6b828989c54d..10883e233b03 100644 --- a/sys/netpfil/pf/if_pfsync.c +++ b/sys/netpfil/pf/if_pfsync.c @@ -706,6 +706,13 @@ pfsync_state_import(union pfsync_state_union *sp, int flags, int msg_version) (st->act.rtableid >= 0 && st->act.rtableid < rt_numfibs))) goto cleanup; + if (sks->proto == IPPROTO_SCTP && st->src.scrub == NULL) { + if (V_pf_status.debug >= PF_DEBUG_MISC) + printf("%s: invalid SCTP state from creator id: %08x\n", __func__, + ntohl(sp->pfs_1301.creatorid)); + goto cleanup; + } + st->id = sp->pfs_1301.id; st->creatorid = sp->pfs_1301.creatorid; pf_state_peer_ntoh(&sp->pfs_1301.src, &st->src);