From owner-cvs-src@FreeBSD.ORG Tue Jun 19 22:40:21 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id BD54716A41F for ; Tue, 19 Jun 2007 22:40:21 +0000 (UTC) (envelope-from pav@FreeBSD.org) Received: from raven.customer.vol.cz (raven.customer.vol.cz [195.250.144.108]) by mx1.freebsd.org (Postfix) with ESMTP id 40DA213C468 for ; Tue, 19 Jun 2007 22:40:21 +0000 (UTC) (envelope-from pav@FreeBSD.org) Received: from [192.168.0.23] (rb5dg130.net.upc.cz [89.176.238.130]) (authenticated bits=0) by raven.customer.vol.cz (8.14.1/8.14.1) with ESMTP id l5JMe8Wl038789 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO); Wed, 20 Jun 2007 00:40:10 +0200 (CEST) (envelope-from pav@FreeBSD.org) From: Pav Lucistnik To: Nate Lawson In-Reply-To: <46782564.70700@root.org> References: <200706182249.l5IMnE4H099470@repoman.freebsd.org> <1182268273.23264.3.camel@erwin.int.cokane.org> <1182268443.21730.75.camel@pav.hide.vol.cz> <1182276521.23264.6.camel@erwin.int.cokane.org> <20070619184124.GA96145@rot13.obsecurity.org> <46782564.70700@root.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-P6eLu9KJHkNlyF427foR" Date: Wed, 20 Jun 2007 00:40:08 +0200 Message-Id: <1182292808.38663.23.camel@ikaros.oook.cz> Mime-Version: 1.0 X-Mailer: Evolution 2.10.1 FreeBSD GNOME Team Port X-Spam-Score: -1.349 () AWL,BAYES_20 X-Scanned-By: MIMEDefang 2.61 on 195.250.144.108 X-Milter: Spamilter (Reciever: raven.customer.vol.cz; Sender-ip: 89.176.238.130; Sender-helo: [192.168.0.23]; ) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Coleman Kane , cvs-all@FreeBSD.org, Kris Kennaway Subject: Re: cvs commit: src/usr.sbin/pkg_install/lib deps.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pav@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jun 2007 22:40:21 -0000 --=-P6eLu9KJHkNlyF427foR Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: quoted-printable Nate Lawson p=ED=B9e v =FAt 19. 06. 2007 v 11:50 -0700: > Kris Kennaway wrote: > > On Tue, Jun 19, 2007 at 02:08:41PM -0400, Coleman Kane wrote: > >> On Tue, 2007-06-19 at 17:54 +0200, Pav Lucistnik wrote: > >>> Coleman Kane p????e v ??t 19. 06. 2007 v 11:51 -0400: > >>>> On Mon, 2007-06-18 at 22:49 +0000, Pav Lucistnik wrote: > >>>>> pav 2007-06-18 22:49:13 UTC > >>>>> > >>>>> FreeBSD src repository (doc,ports committer) > >>>>> > >>>>> Modified files: > >>>>> usr.sbin/pkg_install/lib deps.c=20 > >>>>> Log: > >>>>> - Replace rather inefficient bubble sort with a recursive depth-f= irst search. > >>>>> This speeds up registration of packages considerably. > >>>>> - style(9) police welcome! > >>>>> =20 > >>>>> PR: bin/112630 > >>>>> Submitted by: Stephen Montgomery-Smith > >>>>> Tested by: bento i386 experimental run > >>>>> MFC after: 14 days > >>>>> =20 > >>>>> Revision Changes Path > >>>>> 1.12 +111 -65 src/usr.sbin/pkg_install/lib/deps.c > >>>>> > >>>> Is this by any chance connected to why many of my gnome2 dependencie= s > >>>> would take longer to register than to compile? > >>> Are you observing slowdown registering ports with this patch? > >>> > >> I don't think so. I don't even know if I have the latest sources for > >> pkg_install down yet. > >> > >> I was actually referring to my experience since the x.org modularizati= on > >> that ended up (I think) causing so many dependencies on some packages > >> that registration was awfully slow. I wanted to know if this patch was > >> expected to fix that problem. > >=20 > > Yes, precisely so. >=20 > Excellent! Thanks for working on this, Pav. All fame goes to the submitter, who wrote it, and to Kris, who managed the experimental run. I'm just a scrape goat for purposes of src repo committing :) --=20 Pav Lucistnik The number you dialed is imaginary. Please turn your phone by 90 degrees and try again. --=-P6eLu9KJHkNlyF427foR Content-Type: application/pgp-signature; name=signature.asc Content-Description: Toto je =?UTF-8?Q?digit=C3=A1ln=C4=9B?= =?ISO-8859-1?Q?_podepsan=E1?= =?UTF-8?Q?_=C4=8D=C3=A1st?= =?ISO-8859-1?Q?_zpr=E1vy?= -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD4DBQBGeFtEntdYP8FOsoIRAtjjAJdO+VUboIv3CpfLcrJm9aCeJSATAJ9KEcIC Xv4Xn4bTeCGU2bbf8+cMMQ== =DT4n -----END PGP SIGNATURE----- --=-P6eLu9KJHkNlyF427foR--