From nobody Tue Aug 15 00:33:20 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RPsgh61Dqz4q6YR; Tue, 15 Aug 2023 00:33:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RPsgh5974z3JDB; Tue, 15 Aug 2023 00:33:20 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1692059600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jMVk5j443WFt4SgrRk01t9WmoP4kgVUQNxbSc5ACFgw=; b=eEZYD2SemS2Uk/LIVSBKWhhnd1ZgccNxELBrZofxCLY7tQIqcStC95NWISPhufdeJz6I2Q Hw0CmoeVSlogvebqDwLzB458WQkeqLnDeO4vhSelZAqO2B+ZzMBEAX6+XmMGdCEr4sEWen laN/an8CVx+WupbB7zquGLQ/lfZti2UFVLpdHdi4kFLzBKu7LlfrV1COgp55Yt2ptbpiEa lZTia5hCHIFQfwzRxED6JAq9YgINrtQWjuyUi6R/F1KWFlwhhFO2AvtGTxw6p28xKj8hdw uR9SdegVbQ2T3FJq/GAxMru8SQYH23mZ83Swlqm+VwTDUThX1pvcT5oGGNVjkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1692059600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jMVk5j443WFt4SgrRk01t9WmoP4kgVUQNxbSc5ACFgw=; b=TqF1J3ppRj/VEg7L+KXOKr56ay/8Flxz1Yl3OHZ7urYEE89o9ymBTCxduh+rdHO0J6eXIx xQof4rKZN7arOubuySnKty+xAuo5tf2gFG83hu9U6IFJyhYzyTIjxDRGvTyg57G1EgStop +5e3Ov0eo70VsXrZlAeiCDZhfj4DReVP6IwRlyHTHsQh1iz5tFv6gbbJ+p8vplBsnmwYf3 TZD9BJ40Fpib7pMh49opIrBR20OOGr/DNsdLdLP4m111rZUFMuGQR68ZgC23yziP+hmDKN sFczTfMpebBfLKHcOhp0e6SlCzLn66mokaZy8hc8wRhSYf8DTXK1UT4g0o0pgg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1692059600; a=rsa-sha256; cv=none; b=xFVr7kH3LjEgz+9goJc6ZjV9iC2DXK6HpPC8wSEMetFSsTlVQSLH81HJkgNgLhk1vv0EdC w/uffFnHGSE0jCP/rb2Y114Z6KGNjEMFh6d3/BWLfOTSq0VPX3p8IHr7U1BDJ32k3E+YRJ zsT8HbhPAydMpjDNFsnNYQ0t9dhkmBPRXV5nNd9huiA00cTVm9SwhzOS0HghUuUnvtqja6 4jwIaT8Jb4tT+JyYZjsmQDSvJqMk0a7f4U8bC2C6LiXPB9jGK7VlOUKgMIANhJqKEx9qf8 e5T6PncZXTHVEvILu0enlACKAM/bk0JJsQZCFhf4OrTjESrwbBPT5aeDSmyz9A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RPsgh4FJSzpvY; Tue, 15 Aug 2023 00:33:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 37F0XKC9025258; Tue, 15 Aug 2023 00:33:20 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 37F0XKGe025255; Tue, 15 Aug 2023 00:33:20 GMT (envelope-from git) Date: Tue, 15 Aug 2023 00:33:20 GMT Message-Id: <202308150033.37F0XKGe025255@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: 797e480cba88 - main - e1000: disable TSO on lem(4) and em(4) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 797e480cba8834e584062092c098e60956d28180 Auto-Submitted: auto-generated The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=797e480cba8834e584062092c098e60956d28180 commit 797e480cba8834e584062092c098e60956d28180 Author: Kevin Bowling AuthorDate: 2023-08-15 00:25:39 +0000 Commit: Kevin Bowling CommitDate: 2023-08-15 00:25:39 +0000 e1000: disable TSO on lem(4) and em(4) Disable TSO on lem(4) and em(4) until a ring stall can be debugged. I am not able to reproduce the issue on lem(4) but disabling there in abundance of caution in case the issue is not specific to em(4). Reported by: grog --- sys/dev/e1000/if_em.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/sys/dev/e1000/if_em.c b/sys/dev/e1000/if_em.c index 069ff37c6a75..ca6bf59b5dd1 100644 --- a/sys/dev/e1000/if_em.c +++ b/sys/dev/e1000/if_em.c @@ -906,6 +906,9 @@ em_if_attach_pre(if_ctx_t ctx) scctx->isc_tx_csum_flags = CSUM_TCP | CSUM_UDP | CSUM_IP_TSO | CSUM_IP6_TCP | CSUM_IP6_UDP; + /* Disable TSO on all em(4) until ring stalls can be debugged */ + scctx->isc_capenable &= ~IFCAP_TSO; + /* * Disable TSO on SPT due to errata that downclocks DMA performance * i218-i219 Specification Update 1.5.4.5 @@ -938,6 +941,9 @@ em_if_attach_pre(if_ctx_t ctx) scctx->isc_tx_csum_flags = CSUM_TCP | CSUM_UDP | CSUM_IP_TSO | CSUM_IP6_TCP | CSUM_IP6_UDP; + /* Disable TSO on all lem(4) until ring stalls can be debugged */ + scctx->isc_capenable &= ~IFCAP_TSO; + /* 82541ER doesn't do HW tagging */ if (hw->device_id == E1000_DEV_ID_82541ER || hw->device_id == E1000_DEV_ID_82541ER_LOM) {