From owner-freebsd-xen@FreeBSD.ORG  Wed May 22 17:20:01 2013
Return-Path: <owner-freebsd-xen@FreeBSD.ORG>
Delivered-To: freebsd-xen@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id A4CCD401
 for <freebsd-xen@smarthost.ysv.freebsd.org>;
 Wed, 22 May 2013 17:20:01 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 976A87E2
 for <freebsd-xen@smarthost.ysv.freebsd.org>;
 Wed, 22 May 2013 17:20:01 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r4MHK1eg044319
 for <freebsd-xen@freefall.freebsd.org>; Wed, 22 May 2013 17:20:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r4MHK131044318;
 Wed, 22 May 2013 17:20:01 GMT (envelope-from gnats)
Date: Wed, 22 May 2013 17:20:01 GMT
Message-Id: <201305221720.r4MHK131044318@freefall.freebsd.org>
To: freebsd-xen@FreeBSD.org
Cc: 
From: dfilter@FreeBSD.ORG (dfilter service)
Subject: Re: kern/176471: commit references a PR
X-BeenThere: freebsd-xen@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Discussion of the freebsd port to xen - implementation and usage
 <freebsd-xen.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-xen>,
 <mailto:freebsd-xen-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-xen>
List-Post: <mailto:freebsd-xen@freebsd.org>
List-Help: <mailto:freebsd-xen-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-xen>,
 <mailto:freebsd-xen-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 22 May 2013 17:20:01 -0000

The following reply was made to PR kern/176471; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/176471: commit references a PR
Date: Wed, 22 May 2013 17:13:21 +0000 (UTC)

 Author: gibbs
 Date: Wed May 22 17:13:03 2013
 New Revision: 250913
 URL: http://svnweb.freebsd.org/changeset/base/250913
 
 Log:
   Correct panic on detach of Xen PV network interfaces.
   
   dev/xen/netfront:
       In netif_free(), properly stop the interface and drain any pending
       timers prior to disconnecting from the backend device.
   
       Remove all media and detach our interface object from the system
       prior to deleting it.
   
   PR:		kern/176471
   Submitted by:	Roger Pau Monne <roger.pau@citrix.com>
   Reviewed by:	gibbs
   MFC after:	1 week
 
 Modified:
   head/sys/dev/xen/netfront/netfront.c
 
 Modified: head/sys/dev/xen/netfront/netfront.c
 ==============================================================================
 --- head/sys/dev/xen/netfront/netfront.c	Wed May 22 16:33:28 2013	(r250912)
 +++ head/sys/dev/xen/netfront/netfront.c	Wed May 22 17:13:03 2013	(r250913)
 @@ -2171,10 +2171,14 @@ netfront_detach(device_t dev)
  static void
  netif_free(struct netfront_info *info)
  {
 +	XN_LOCK(info);
 +	xn_stop(info);
 +	XN_UNLOCK(info);
 +	callout_drain(&info->xn_stat_ch);
  	netif_disconnect_backend(info);
 -#if 0
 -	close_netdev(info);
 -#endif
 +	ifmedia_removeall(&info->sc_media);
 +	ether_ifdetach(info->xn_ifp);
 +	if_free(info->xn_ifp);
  }
  
  static void
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"