From owner-freebsd-alpha Wed Aug 26 18:25:21 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id SAA04870 for freebsd-alpha-outgoing; Wed, 26 Aug 1998 18:25:21 -0700 (PDT) (envelope-from owner-freebsd-alpha@FreeBSD.ORG) Received: from fleming.cs.strath.ac.uk (fleming.cs.strath.ac.uk [130.159.196.126]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id SAA04828 for ; Wed, 26 Aug 1998 18:25:07 -0700 (PDT) (envelope-from roger@cs.strath.ac.uk) Received: from neipc-17.cs.strath.ac.uk (scary.dmem.strath.ac.uk [130.159.202.5]) by fleming.cs.strath.ac.uk (8.8.8/8.8.8) with SMTP id CAA19332 Thu, 27 Aug 1998 02:24:15 +0100 (BST) Message-ID: <35E4B618.56FD@cs.strath.ac.uk> Date: Thu, 27 Aug 1998 02:27:52 +0100 From: Roger Hardiman Organization: University of Strathclyde X-Mailer: Mozilla 3.01 (Win95; I) MIME-Version: 1.0 To: freebsd-alpha@FreeBSD.ORG Subject: Recent Alpha typecast to brooktre848.c Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-alpha@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org Hi, I work on the bt848 driver and was looking at the recent typecast change from "u_long" to "(uintptr_t) (void*)" in the driver. Logs state this was for the Alpha kernel. I think this may be incorrect. < *(*dma_prog)++ = (uintptr_t) (void *) *target_buffer; --- > *(*dma_prog)++ = (u_long) *target_buffer; The block of memory *dma_prog is pointing to is the instruction list for the bt848 chip's internal RISC processor. This is a set of 32 bit instructions. uintptr_t is defined as an unsigned long in Alpha/types.h so should this be a typecast to u_int32 and not uintptr_t Can someone working on this drop me an email. There are lots of other (u_long) type casts in the driver when writing to the dma_prog buffer which may need fixing. Cheers Roger Hardiman To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-alpha" in the body of the message