Date: Fri, 22 Mar 2013 19:06:07 +0400 From: Boris Samorodov <bsam@passap.ru> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, Baptiste Daroussin <bapt@FreeBSD.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r314859 - head/palm/jpilot Message-ID: <514C735F.1050005@passap.ru> In-Reply-To: <20130322145344.GA16844@FreeBSD.org> References: <201303211827.r2LIRHrh078301@svn.freebsd.org> <514C6DEF.10201@passap.ru> <20130322145344.GA16844@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
22.03.2013 18:53, Alexey Dokuchaev пишет: > On Fri, Mar 22, 2013 at 06:42:55PM +0400, Boris Samorodov wrote: >> 21.03.2013 22:27, Baptiste Daroussin пишет: >>> --- head/palm/jpilot/Makefile Thu Mar 21 18:25:04 2013 (r314858) >>> +++ head/palm/jpilot/Makefile Thu Mar 21 18:27:17 2013 (r314859) >> [...] >>> -# "?=" and "+=" are for including this Makefile from japanese/jpilot >> >> Not particular to this commit, but rather a general question: >> what is our current policy on comments at the makefile headers? >> I mean non-standard comments (maintainer tips, etc.). Should >> they be deleted? > > I would not delete them (in general case). ACK. > In this particular case I assume > they were deleted because they were stating quite obvious thing: certain > variables with +=/?= are clear indication of master/slave relationship. Unfortunately our standard tool makes this: ----- bsam% cd /usr/ports/palm/jpilot bsam% grep ^# Makefile # Created by: Alex Varju <varju@webct.com> # $FreeBSD: head/palm/jpilot/Makefile 314859 2013-03-21 18:27:17Z bapt $ # Do not edit this makefile header!!! bsam% /usr/ports/Tools/scripts/convert-makefile-header.pl ./Makefile converted bsam% grep ^# Makefile # Created by: Alex Varju <varju@webct.com> # $FreeBSD$ ----- -- WBR, Boris Samorodov (bsam) FreeBSD Committer, http://www.FreeBSD.org The Power To Serve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?514C735F.1050005>