From nobody Tue Aug 22 16:19:25 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RVZLH07JQz4r5jP; Tue, 22 Aug 2023 16:19:35 +0000 (UTC) (envelope-from rodrigo@FreeBSD.org) Received: from smtp.osorio.me (mvd.osorio.me [5.196.94.126]) by mx1.freebsd.org (Postfix) with ESMTP id 4RVZLG2PJ4z4X9m; Tue, 22 Aug 2023 16:19:34 +0000 (UTC) (envelope-from rodrigo@FreeBSD.org) Authentication-Results: mx1.freebsd.org; none Received: from [192.168.66.57] (ns3309494.ip-5-135-160.eu [5.135.160.30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by smtp.osorio.me (Postfix) with ESMTPSA id A11B21C7025; Tue, 22 Aug 2023 16:19:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="------------voXms1ihblX8krx0UkZTmJSF" Message-ID: <226220f0-119d-79d1-c597-064990d6cb6f@FreeBSD.org> Date: Tue, 22 Aug 2023 18:19:25 +0200 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: git: 11e51925413b - main - devel/p5-DateTime-Format-MySQL: Update to 0.08 Content-Language: en-US, fr, es-AR To: Po-Chuan Hsieh , Joseph Mingrone Cc: Renato Botelho , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org References: <202308161836.37GIaHp6043137@gitrepo.freebsd.org> <86jzttx00m.fsf@phe.ftfl.ca> <867cpsp4hi.fsf@phe.ftfl.ca> <6cb25b46-33e1-4ab6-8207-c3087c08a7a5@FreeBSD.org> <867cpsnmuh.fsf@phe.ftfl.ca> From: Rodrigo Osorio Reply-To: rodrigo@FreeBSD.org In-Reply-To: X-Rspamd-Queue-Id: 4RVZLG2PJ4z4X9m X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16276, ipnet:5.196.0.0/16, country:FR] This is a multi-part message in MIME format. --------------voXms1ihblX8krx0UkZTmJSF Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 21/08/23 20:11, Po-Chuan Hsieh wrote: > On Sat, Aug 19, 2023 at 3:59 AM Joseph Mingrone wrote: > > On Fri, 2023-08-18 at 16:08, Renato Botelho wrote: > > > On 18/08/23 15:52, Joseph Mingrone wrote: > >> On Fri, 2023-08-18 at 14:32, Renato Botelho > wrote: > > >>> On 17/08/23 10:37, Joseph Mingrone wrote: > >>>> On Thu, 2023-08-17 at 10:15, Renato Botelho > wrote: > > >>>>> On 16/08/23 15:36, Po-Chuan Hsieh wrote: > >>>>>> The branch main has been updated by sunpoet: > >>>>>> URL: > https://cgit.FreeBSD.org/ports/commit/?id=11e51925413b7090544d4a4ac449c364717f7e50 > > >>>>>> commit 11e51925413b7090544d4a4ac449c364717f7e50 > >>>>>> Author:     Po-Chuan Hsieh > >>>>>> AuthorDate: 2023-08-16 18:16:29 +0000 > >>>>>> Commit:     Po-Chuan Hsieh > >>>>>> CommitDate: 2023-08-16 18:26:21 +0000 > >>>>>> devel/p5-DateTime-Format-MySQL: Update to 0.08 > >>>>>>             Changes: > https://metacpan.org/dist/DateTime-Format-MySQL/changes > >>>>>> --- > >>>>>>  devel/p5-DateTime-Format-MySQL/Makefile | 2 +- > >>>>>>  devel/p5-DateTime-Format-MySQL/distinfo | 6 +++--- > >>>>>>     2 files changed, 4 insertions(+), 4 deletions(-) > >>>>>> diff --git a/devel/p5-DateTime-Format-MySQL/Makefile > b/devel/p5-DateTime-Format-MySQL/Makefile > >>>>>> index 989d481a74d2..f9b0e03be278 100644 > >>>>>> --- a/devel/p5-DateTime-Format-MySQL/Makefile > >>>>>> +++ b/devel/p5-DateTime-Format-MySQL/Makefile > >>>>>> @@ -1,5 +1,5 @@ > >>>>>>     PORTNAME= DateTime-Format-MySQL > >>>>>> -PORTVERSION=    0.0701 > >>>>>> +PORTVERSION=    0.08 > > >>>>> Hello Po-Chuan! > > >>>>> 0.08 is smaller than 0.0701 so port version went backwards > after this change. > >>>> 0.08 is greater than 0.0701, but not according to pkg version. > >>>>    % pkg version -t 0.08 0.0701 > >>>>           < > > >>> Actually pkg is correct in this case. Numerically 8 is smaller > than 701.  I tested it on Ubuntu and dpkg --compare-versions has > the same result, and I believe any other package management tool > will do. > > >>> What seems to be wrong is the version schema used by this > project.  It should be 0.0800 instead of 0.08. > >> I didn't mean to suggest that pkg is wrong, but just pointing > out that numerically, 0.08, which is equal to 0.0800, is greater > than 0.0701.  This could be a source of confusion for anyone who > assumes that the comparison of version numbers works the same as > comparisons of > >> real numbers. > > > Anyway, can you please fix the port by adding PORTEPOCH? > > Fixed in 49eb4309189da197f55dee54f8efb5e875f2daaa.  Thanks for > reporting. > > Joe > > > No doubt 0.08 is less than 0.0701 in the pkg world. > Thank you all for fixing it. > > We don't know if the versioning change is temporary or not. Instead of > adding PORTEPOCH, please consider the following fix/hack next time. > Thanks again. > > --- a/devel/p5-DateTime-Format-MySQL/Makefile > +++ b/devel/p5-DateTime-Format-MySQL/Makefile > @@ -1,8 +1,9 @@ >  PORTNAME=      DateTime-Format-MySQL > -PORTVERSION=   0.08 > +PORTVERSION=   0.0800 >  CATEGORIES=    devel perl5 >  MASTER_SITES=  CPAN >  PKGNAMEPREFIX= p5- > +DISTNAME=      DateTime-Format-MySQL-${PORTVERSION:C|00$||} > >  MAINTAINER= perl@FreeBSD.org >  COMMENT=       Parse and format MySQL dates and times Hi, I don't know if such a simple fix can solve the issue we have with Perl versioning sheme and the semantic versioning scheme we use in ports. This article is very instructive about how awful it is https://perlhacks.com/2016/12/version-numbers/. Just a few examples running this command to evaluate the version number:     perl -Mversion -E"say version->parse('$VERSION')->normal" VERSION    | Output -----------|------- "8"        | v8.0.0 "00008"    | v8.0.0 "000080"   | v80.0.0 "0.8"      | v0.800.0 "0.81"     | v0.810.0 "0.801"    | v0.801.0 "0.8001"   | v0.800.100 "0.008001" | v0.8.1 By the way, I did a quick try in with your fix, and the substitution with an '$' doesn't seem to work in BSD makefiles. %cat Makefile V="0.0800" all:     @echo ${V}     @echo ${V:C|00$||} %make 0.0800 0.0800 Regards -- rodrigo --------------voXms1ihblX8krx0UkZTmJSF Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit
On 21/08/23 20:11, Po-Chuan Hsieh wrote:
On Sat, Aug 19, 2023 at 3:59 AM Joseph Mingrone <jrm@freebsd.org> wrote:
On Fri, 2023-08-18 at 16:08, Renato Botelho <garga@FreeBSD.org> wrote:

> On 18/08/23 15:52, Joseph Mingrone wrote:
>> On Fri, 2023-08-18 at 14:32, Renato Botelho <garga@FreeBSD.org> wrote:

>>> On 17/08/23 10:37, Joseph Mingrone wrote:
>>>> On Thu, 2023-08-17 at 10:15, Renato Botelho <garga@FreeBSD.org> wrote:

>>>>> On 16/08/23 15:36, Po-Chuan Hsieh wrote:
>>>>>> The branch main has been updated by sunpoet:
>>>>>> URL: https://cgit.FreeBSD.org/ports/commit/?id=11e51925413b7090544d4a4ac449c364717f7e50
>>>>>> commit 11e51925413b7090544d4a4ac449c364717f7e50
>>>>>> Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
>>>>>> AuthorDate: 2023-08-16 18:16:29 +0000
>>>>>> Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
>>>>>> CommitDate: 2023-08-16 18:26:21 +0000
>>>>>>        devel/p5-DateTime-Format-MySQL: Update to 0.08
>>>>>>             Changes:        https://metacpan.org/dist/DateTime-Format-MySQL/changes
>>>>>> ---
>>>>>>     devel/p5-DateTime-Format-MySQL/Makefile | 2 +-
>>>>>>     devel/p5-DateTime-Format-MySQL/distinfo | 6 +++---
>>>>>>     2 files changed, 4 insertions(+), 4 deletions(-)
>>>>>> diff --git a/devel/p5-DateTime-Format-MySQL/Makefile b/devel/p5-DateTime-Format-MySQL/Makefile
>>>>>> index 989d481a74d2..f9b0e03be278 100644
>>>>>> --- a/devel/p5-DateTime-Format-MySQL/Makefile
>>>>>> +++ b/devel/p5-DateTime-Format-MySQL/Makefile
>>>>>> @@ -1,5 +1,5 @@
>>>>>>     PORTNAME=    DateTime-Format-MySQL
>>>>>> -PORTVERSION=    0.0701
>>>>>> +PORTVERSION=    0.08

>>>>> Hello Po-Chuan!

>>>>> 0.08 is smaller than 0.0701 so port version went backwards after this change.
>>>> 0.08 is greater than 0.0701, but not according to pkg version.
>>>>    % pkg version -t 0.08 0.0701
>>>>           <

>>> Actually pkg is correct in this case.  Numerically 8 is smaller than 701.  I tested it on Ubuntu and dpkg --compare-versions has the same result, and I believe any other package management tool will do.

>>> What seems to be wrong is the version schema used by this project.  It should be 0.0800 instead of 0.08.
>> I didn't mean to suggest that pkg is wrong, but just pointing out that numerically, 0.08, which is equal to 0.0800, is greater than 0.0701.  This could be a source of confusion for anyone who assumes that the comparison of version numbers works the same as comparisons of
>> real numbers.

> Anyway, can you please fix the port by adding PORTEPOCH?

Fixed in 49eb4309189da197f55dee54f8efb5e875f2daaa.  Thanks for reporting.

Joe

No doubt 0.08 is less than 0.0701 in the pkg world.
Thank you all for fixing it.

We don't know if the versioning change is temporary or not. Instead of adding PORTEPOCH, please consider the following fix/hack next time.
Thanks again.

--- a/devel/p5-DateTime-Format-MySQL/Makefile
+++ b/devel/p5-DateTime-Format-MySQL/Makefile
@@ -1,8 +1,9 @@
 PORTNAME=      DateTime-Format-MySQL
-PORTVERSION=   0.08
+PORTVERSION=   0.0800
 CATEGORIES=    devel perl5
 MASTER_SITES=  CPAN
 PKGNAMEPREFIX= p5-
+DISTNAME=      DateTime-Format-MySQL-${PORTVERSION:C|00$||}

 MAINTAINER=    perl@FreeBSD.org
 COMMENT=       Parse and format MySQL dates and times
 

Hi,

I don't know if such a simple fix can solve the issue we have with Perl versioning sheme
and the semantic versioning scheme we use in ports.
This article is very instructive about how awful it is https://perlhacks.com/2016/12/version-numbers/.

Just a few examples running this command to evaluate the version number:
    perl -Mversion -E"say version->parse('$VERSION')->normal"

VERSION    | Output
-----------|-------
"8"        | v8.0.0
"00008"    | v8.0.0
"000080"   | v80.0.0
"0.8"      | v0.800.0
"0.81"     | v0.810.0
"0.801"    | v0.801.0
"0.8001"   | v0.800.100
"0.008001" | v0.8.1

By the way, I did a quick try in with your fix, and the substitution with an '$'
doesn't seem to work in BSD makefiles.

%cat Makefile
V="0.0800"
all:
    @echo ${V}
    @echo ${V:C|00$||}

%make
0.0800
0.0800

Regards
-- rodrigo

--------------voXms1ihblX8krx0UkZTmJSF--