From owner-cvs-usrsbin  Mon Nov 10 13:29:04 1997
Return-Path: <owner-cvs-usrsbin>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id NAA00139
          for cvs-usrsbin-outgoing; Mon, 10 Nov 1997 13:29:04 -0800 (PST)
          (envelope-from owner-cvs-usrsbin)
Received: from awfulhak.demon.co.uk (awfulhak.demon.co.uk [158.152.17.1])
          by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id NAA00116;
          Mon, 10 Nov 1997 13:28:43 -0800 (PST)
          (envelope-from brian@awfulhak.org)
Received: from gate.lan.awfulhak.org (localhost [127.0.0.1])
	by awfulhak.demon.co.uk (8.8.7/8.8.5) with ESMTP id VAA07993;
	Mon, 10 Nov 1997 21:16:28 GMT
Message-Id: <199711102116.VAA07993@awfulhak.demon.co.uk>
X-Mailer: exmh version 2.0zeta 7/24/97
To: Eivind Eklund <perhaps@yes.no>
cc: Brian Somers <brian@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG,
        cvs-all@FreeBSD.ORG, cvs-usrsbin@FreeBSD.ORG
Subject: Re: cvs commit: src/usr.sbin/ppp ccp.c command.c ipcp.c lcp.c lcp.h main.c modem.c modem.h os.c route.c 
In-reply-to: Your message of "Mon, 10 Nov 1997 13:28:43 +0100."
             <199711101228.NAA17807@bitbox.follo.net> 
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Mon, 10 Nov 1997 21:16:28 +0000
From: Brian Somers <brian@awfulhak.org>
Sender: owner-cvs-usrsbin@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

> > 
> > brian       1997/11/07 16:28:12 PST
> > 
> >   Modified files:
> >     usr.sbin/ppp         ccp.c command.c ipcp.c lcp.c lcp.h main.c 
> >                          modem.c modem.h os.c route.c 
> >   Log:
> >   Don't pass global vars as args.
> 
> I don't think patching away that is a good idea.  The goal should be
> to make the global variables static/local; this kind of passing should
> be introduced more places, not removed.  Then you can make the global
> variable static/dynamic somewhere later.

I agree.  I hate globals with a vengence :-|  They'll all go at some 
point.  The above was a quick improvement so that there's now no 
obscure name-space confusion.

Once I get the security stuff finished, I'm going to try implementing 
a multilink capability.  I'm trying to get comfortable with 
everything in the code first so that I don't go breaking 
functionality that I don't already know about :-)

> IMNSHO,
> Eivind.

-- 
Brian <brian@Awfulhak.org>, <brian@FreeBSD.org>, <bri@OpenBSD.org>
      <http://www.Awfulhak.org>
Don't _EVER_ lose your sense of humour....