Date: Mon, 13 Apr 2015 05:55:08 +0200 From: Jan Beich <jbeich@FreeBSD.org> To: John Marino <freebsd.contact@marino.st> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, John Marino <marino@FreeBSD.org>, ports-committers@freebsd.org Subject: Re: svn commit: r383843 - head/games/megaglest Message-ID: <7ftg-el7n-wny@FreeBSD.org> References: <201504120832.t3C8W2oh056956@svn.freebsd.org> <7fth-sdr1-wny@FreeBSD.org> <552AA964.4000306@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable John Marino <freebsd.contact@marino.st> writes: >> John Marino <marino@FreeBSD.org> writes: >>=20 >>> Megaglest cannot be built under c++11 standard from the latest clang. >>> It catches a narrowing error. The real solution is to fix the c++ >>> code (it wasn't the only problem, but the first to trigger an error o= ver >>> a warning). The c++11 standard is required for wx, so it can't be >>> unspecified. It turns out that gcc48 will not catch the error that c= lang >>> does so the temporary fix is to require gcc48 for all FreeBSD release= s. >>> This may work for gcc49 as well, but it's likely that gcc5 will also >>> catch the bug and break. >>=20 >> CXXFLAGS +=3D -Wno-c++11-narrowing ? GCC ignores unknown -Wno-foo. >>=20 >> Or maybe poke upstream if it has a fix: >>=20 >> #v+ >> Clang fix for tdefl_write_image_to_png_file_in_memory() from toffaletti https://code.google.com/p/miniz/issues/detail?id=3D6 >> --- source/shared_lib/sources/miniz/miniz.c (revision 56) >> +++ source/shared_lib/sources/miniz/miniz.c (revision 57) > > > IIUC - you're saying 1) what I did builds but doesn't work and 2) you've > got a patch that will let it build on clang. The part you've trimmed was an implicit request to _backout_ USE_GCC workarounds here and in r383839. megaglest fix is a by-product of trying to check how easy the homework was. > If I got that right, just go ahead and commit it. Are you flying solo > or with implicit permission these days? Low priority, sorry. My hardware is too slow to build-test properly. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQF8BAEBCgBmBQJVKz4cXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3bGQ8H+gM8iSlhuJWHRhQz2Yt8AFHJ duy8EzuRFUH9QZjsfrEin0WIa2O3z2aOCeCdZM0XPOULrMqPdSKXFonzXRDMe0L6 7K1y4sr+uiSEu21HoCR+ivSmAUR4B+aYfQT7Np8+J26tBcoOKDGFQlDVi3XZfU7o m+hmO4KQUPiQLj0aWsXLeIrtDGX8zzkBvZuGsM/okCatu5AXromr+U2WRCybheIL hK+bfxykNhtcps0t4m/DcFtf7JcuzBmYx2rLdo7NCQw3II/x41Oc5ekGIL7uIDdQ cMU30X/9VmP8Q0jmleI1jWsfiw8KCmZrVDKSXUSx9AUSgjZL7XlixhyVxQ8wggs= =JEIz -----END PGP SIGNATURE----- --=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7ftg-el7n-wny>