From owner-freebsd-arch@FreeBSD.ORG Mon Feb 20 09:03:08 2012 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5A9A51065670; Mon, 20 Feb 2012 09:03:08 +0000 (UTC) (envelope-from to.my.trociny@gmail.com) Received: from mail-ee0-f54.google.com (mail-ee0-f54.google.com [74.125.83.54]) by mx1.freebsd.org (Postfix) with ESMTP id 896138FC08; Mon, 20 Feb 2012 09:03:07 +0000 (UTC) Received: by eekb47 with SMTP id b47so2390848eek.13 for ; Mon, 20 Feb 2012 01:03:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:organization:references:sender:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=EZvtxh//YN97GwGk1A91N1n0s2orMdsTPN8vUS65uO4=; b=IluSlaN1ly6fm5Bf3GhxzzSdDdlj1tvo0JM1ZVNkwonx0buEcvJv4OUGzkQVaqDq+J SjK+zwkSrCclPrHSWfWmUCXB5KUCdQaQ82r0Jspihn+CLodmWakymKPedGsZC0NKWEpS XTkJ8TdVOzmTFByVyNrBMbEtn8z4yDVxagZ7I= Received: by 10.14.94.66 with SMTP id m42mr7916915eef.66.1329728586478; Mon, 20 Feb 2012 01:03:06 -0800 (PST) Received: from localhost ([94.27.39.186]) by mx.google.com with ESMTPS id c16sm75494186eei.1.2012.02.20.01.03.02 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 20 Feb 2012 01:03:04 -0800 (PST) From: Mikolaj Golub To: Konstantin Belousov Organization: TOA Ukraine References: <86fwfnti5t.fsf@kopusha.home.net> <20120112215106.GC31224@deviant.kiev.zoral.com.ua> <86hazntwmu.fsf@kopusha.home.net> <20120123031238.GL31224@deviant.kiev.zoral.com.ua> <86zkcfu9ac.fsf@kopusha.home.net> <20120218215003.GM3283@deviant.kiev.zoral.com.ua> <86ehtrf8qf.fsf@kopusha.home.net> <20120219170151.GS3283@deviant.kiev.zoral.com.ua> Sender: Mikolaj Golub Date: Mon, 20 Feb 2012 11:02:59 +0200 In-Reply-To: <20120219170151.GS3283@deviant.kiev.zoral.com.ua> (Konstantin Belousov's message of "Sun, 19 Feb 2012 19:01:51 +0200") Message-ID: <8662f1q3lo.fsf@in138.ua3> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Robert N. M. Watson" , freebsd-arch@freebsd.org Subject: Re: unix domain sockets on nullfs(5) X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Feb 2012 09:03:08 -0000 On Sun, 19 Feb 2012 19:01:51 +0200 Konstantin Belousov wrote: KB> On Sun, Feb 19, 2012 at 11:55:20AM +0200, Mikolaj Golub wrote: >> >> On Sat, 18 Feb 2012 23:50:03 +0200 Konstantin Belousov wrote: >> >> KB> On Sat, Feb 18, 2012 at 11:22:03PM +0200, Mikolaj Golub wrote: >> >> After collecting all suggestions and additional testing I have got this patch >> >> set: >> >> >> >> http://people.freebsd.org/~trociny/unp_prepare_reclaim.1.patch >> KB> Including unpcb.h into vfs_subr.c looks too extreme. Put the prototype >> KB> into vnode.h, possibly renaming the function to vfs_unp_reclaim. >> >> Done. >> >> >> http://people.freebsd.org/~trociny/unp_connect.LOCKSHARED.1.patch >> >> http://people.freebsd.org/~trociny/VOP_UNP.3.patch >> KB> I has a painting suggestion there, call the vops VOP_UNP_DETACH etc, >> KB> otherwise it takes too much reading to understand that it is not undetach. >> >> Unfortunately, vnode_if.awk does not support underscores in VOP names. It >> failed with "Invalid %% construction" due to the restriction: $2 !~ /^[a-z]+$/. >> So I reverted back to the old naming. KB> Ok, might be it makes sense to try to add underscore to the set of KB> allowed symbols. It does not look difficult and the patch is trivial: http://people.freebsd.org/~trociny/vnode_if.awk.patch I built and booted the kernel with VOP_UNP_* using it. I could commit if other people are ok with this and don't see issues. >> >> The updated patches: >> >> http://people.freebsd.org/~trociny/unp_prepare_reclaim.2.patch >> http://people.freebsd.org/~trociny/unp_connect.LOCKSHARED.1.patch >> http://people.freebsd.org/~trociny/VOP_UNP.4.patch KB> In the comment above vfs_unp_reclaim(), say "before socket-type vnode KB> reclamation". KB> I have no further comments. Thanks. -- Mikolaj Golub