From owner-freebsd-current@FreeBSD.ORG Tue May 29 06:32:10 2007 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0D8BA16A4C5 for ; Tue, 29 May 2007 06:32:10 +0000 (UTC) (envelope-from danny@cs.huji.ac.il) Received: from cs1.cs.huji.ac.il (cs1.cs.huji.ac.il [132.65.16.10]) by mx1.freebsd.org (Postfix) with ESMTP id BDA8213C4AE for ; Tue, 29 May 2007 06:32:09 +0000 (UTC) (envelope-from danny@cs.huji.ac.il) Received: from pampa.cs.huji.ac.il ([132.65.80.32]) by cs1.cs.huji.ac.il with esmtp id 1HsvFY-0003b2-FU for freebsd-current@freebsd.org; Tue, 29 May 2007 09:32:08 +0300 X-Mailer: exmh version 2.7.2 01/07/2005 with nmh-1.2 To: freebsd-current@freebsd.org In-reply-to: Your message of Tue, 8 May 2007 19:00:15 +0000 . Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 29 May 2007 09:32:08 +0300 From: Danny Braniss Message-ID: Subject: Re: INCLUDE_CONFIG_FILE patches X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 May 2007 06:32:10 -0000 > On Tue, May 08, 2007 at 07:35:02PM +0200, Adrian Steinmann wrote: > > On Mon, May 07, 2007 at 07:46:29PM +0400, pluknet wrote: > > > On 06/05/07, Wojciech A. Koszek wrote: > > > >We talked about improved INCLUDE_CONFIG_FILE work some time ago. I > > > >cleaned it up, and I have prepared a patch for the latest -CURRENT. > > > > > > [..] > > > I would like to suggest -x instead of -k, to align it with netbsd > > which has this feature (including comments). > > > > Good suggestion some problems: config -x /boot/kernel/kernel | rep options gives: Binary file (standard input) matches because the last byte is a NULL. (why *grep thinks that if the last byte is binary, then the whole file is, escapes me) another thing: in sys/conf/Notes, the commnet on how to obtain the cofiguration file should be updated. and finally, it would have been realy nice, if the file UPDATE would have mentioned how to obtain the configuration file. danny