From owner-svn-ports-all@FreeBSD.ORG  Sat Mar 16 18:48:07 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 5B908DE3;
 Sat, 16 Mar 2013 18:48:07 +0000 (UTC)
 (envelope-from kwm@rainbow-runner.nl)
Received: from fep12.mx.upcmail.net (fep12.mx.upcmail.net [62.179.121.32])
 by mx1.freebsd.org (Postfix) with ESMTP id 0AB2BE27;
 Sat, 16 Mar 2013 18:48:05 +0000 (UTC)
Received: from edge04.upcmail.net ([192.168.13.239]) by viefep12-int.chello.at
 (InterMail vM.8.01.05.05 201-2260-151-110-20120111) with ESMTP
 id <20130316184804.BIVA14414.viefep12-int.chello.at@edge04.upcmail.net>;
 Sat, 16 Mar 2013 19:48:04 +0100
Received: from [127.0.0.1] ([178.84.132.32]) by edge04.upcmail.net with edge
 id CJo21l00u0i5fp604Jo2Dz; Sat, 16 Mar 2013 19:48:04 +0100
X-SourceIP: 178.84.132.32
Message-ID: <5144BE63.8020602@rainbow-runner.nl>
Date: Sat, 16 Mar 2013 19:48:03 +0100
From: Koop Mast <kwm@rainbow-runner.nl>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:17.0) Gecko/20130307 Thunderbird/17.0.4
MIME-Version: 1.0
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Subject: Re: svn commit: r314380 - head/graphics/colord
References: <201303161736.r2GHas76043600@svn.freebsd.org>
 <20130316174725.GA67587@FreeBSD.org>
In-Reply-To: <20130316174725.GA67587@FreeBSD.org>
Content-Type: text/plain; charset=KOI8-R; format=flowed
Content-Transfer-Encoding: 7bit
X-Antivirus: avast! (VPS 130316-0, 16-03-2013), Outbound message
X-Antivirus-Status: Clean
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Mar 2013 18:48:07 -0000

On 16-3-2013 18:47, Alexey Dokuchaev wrote:
> On Sat, Mar 16, 2013 at 05:36:54PM +0000, Koop Mast wrote:
>> New Revision: 314380
>> URL: http://svnweb.freebsd.org/changeset/ports/314380
>>
>> Log:
>>    Prevert ! instead of empty() and fix a typo.
> It seems you've fixed typo in original submission, not in the Makefile. :)
> Could be confusing.
no take a closer look its a "empty(" and then closed with a "}", sneaky huh.

>
>> @@ -57,7 +57,7 @@ post-patch:
>>   		-e 's|-Wmissing-parameter-type||g' \
>>   		-e 's|LIBS="-lusb-1.0|LIBS="-lusb|g' \
>>   		${WRKSRC}/configure
>> -.if empty(PORT_OPTIONS:MMANPAGES}
>> +.if !${PORT_OPTIONS:MMANPAGES}
> It's usually better to pad ! with a space after it, helps to stand out.
>
> ./danfe
Ah I will try to keep that in mind for the next time.