From nobody Tue Feb 24 14:26:04 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fL0QB3Ww3z6S9wW for ; Tue, 24 Feb 2026 14:26:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fL0QB2VCcz3TNC for ; Tue, 24 Feb 2026 14:26:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771943170; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+qPrg7naIr2VU+Zeg4F3ADs8OyeUybPYPvjp5OyAmjA=; b=pEati6HcOoNhh6tIf4CZh/PA11H9gD0cLE7feP7PX9iNXb6eC4zyCwL+hkGCFOvhaIl8W+ AVMndf+J5ctYuNGFbZ6PhWyaCecueu697jOQZ2jKqpYEvty3u3xrXNl3w4m/4B0vASLzZh gKhB4MkqDFW2oHc/IG9RKUUo6x7E6gQ3nYOWY/GOIt6zQXKxywe1fWSargemLhziMsGZ5u 1FXVRxbqTZhvOWtjA3SVuy2gQ8gsw1H7eOAcYAwougnJoKCIg1rFl4XZMeTG6nFq6UhAAo pribsbig1hlTjwNEoEuqjHNtjA3vQ8trrb+bAU8q79aFfgp89d8pv9IeOFNMwA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1771943170; a=rsa-sha256; cv=none; b=J/v2BWIefxFyN6zokDLWAiaD46AvxYDJPkZ5cW/s8jNAxrnbPuyBOVJFq79Y2ajOrVr2gF 0rO5A0spcTiy5wrrNZPhaAOW6blLXHBcF0uZ3YsOIejr6Gkcme/A0X7wRlYXxqRIunxG6X ZvuLPKwDJin01rMmT1kzTsAQbabmKBhxj/u4arAkqpY0C/eZ6ztWvj4qe0dH80dXCVYpkX Br628/SYGFtvrTkVeOP5vk0mbzmshz5JeeOKN32hvgfv2hXMGglNk1q9eMsEF7WHIM55Q4 LYIlemudOIofdC7c0lHxZjzTSBtWPE01dwye9A63t5CZ7jWg49ljcAqI1QODSw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771943170; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+qPrg7naIr2VU+Zeg4F3ADs8OyeUybPYPvjp5OyAmjA=; b=cJnW9yZVImLbxOm4HgCzp/lsGdnTT7Z01oy099+21PRJtOyCNqb2rRVTjc1KnjjxyHHNfS Fri/bbD5wka71YdS4JPda72HDRInWXd/3JR2jPSEECFiiaFgVwj/YID2xGBk6r4yDuixxp 1dHaEH5WXFCXeRAF+YrlvygDplkiwApq3zOwO1T1jbbFzQMxMRBnnVNGIIqkei4bSqIQ1e zKVd0QoY0Ci+CAJBAtN+YVej7C5dZ+g0ZU9YW1m7Fqf1nHXKpdGzQRtcYp7I00aRU7GEpl GtE4ZN433jJSYW8MTyhC1IfDyx5HzB5on5VsXDiyc2enhKXW7GKuRaszUd1u7g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fL0QB14qFz3lq for ; Tue, 24 Feb 2026 14:26:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1cf24 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 24 Feb 2026 14:26:04 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: 6c4777c59325 - main - ngctl: Fix getline loop List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6c4777c59325c2cfefcce0c466b3bf475404a550 Auto-Submitted: auto-generated Date: Tue, 24 Feb 2026 14:26:04 +0000 Message-Id: <699db4fc.1cf24.4f3430f0@gitrepo.freebsd.org> The branch main has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=6c4777c59325c2cfefcce0c466b3bf475404a550 commit 6c4777c59325c2cfefcce0c466b3bf475404a550 Author: Dag-Erling Smørgrav AuthorDate: 2026-02-24 14:23:39 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-02-24 14:25:57 +0000 ngctl: Fix getline loop I misremembered when I wrote this code: getline() returns -1 on EOF, not zero, so the loop condition and the error check are both incorrect (though in practice getline() will never return 0). MFC after: 3 days Fixes: 3cbdcabf714d ("ngctl: Modernize code somewhat") Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D55487 --- usr.sbin/ngctl/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/usr.sbin/ngctl/main.c b/usr.sbin/ngctl/main.c index b58de1e042b3..2b711fd4155a 100644 --- a/usr.sbin/ngctl/main.c +++ b/usr.sbin/ngctl/main.c @@ -243,7 +243,7 @@ ReadFile(FILE *fp) unsigned int lineno = 0; int rtn = CMDRTN_OK; - while ((len = getline(&line, &sz, fp)) > 0) { + while ((len = getline(&line, &sz, fp)) >= 0) { lineno++; if (*line == '#') continue; @@ -252,7 +252,7 @@ ReadFile(FILE *fp) break; } } - if (len < 0) + if (ferror(fp)) rtn = CMDRTN_ERROR; free(line); return (rtn);