From owner-freebsd-ports@freebsd.org  Sat May  7 07:09:27 2016
Return-Path: <owner-freebsd-ports@freebsd.org>
Delivered-To: freebsd-ports@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 640AFB31782
 for <freebsd-ports@mailman.ysv.freebsd.org>;
 Sat,  7 May 2016 07:09:27 +0000 (UTC) (envelope-from lists@opsec.eu)
Received: from home.opsec.eu (home.opsec.eu [IPv6:2001:14f8:200::1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 25DB014EF
 for <freebsd-ports@freebsd.org>; Sat,  7 May 2016 07:09:27 +0000 (UTC)
 (envelope-from lists@opsec.eu)
Received: from pi by home.opsec.eu with local (Exim 4.87 (FreeBSD))
 (envelope-from <lists@opsec.eu>)
 id 1aywMf-0001dx-Is; Sat, 07 May 2016 09:09:25 +0200
Date: Sat, 7 May 2016 09:09:25 +0200
From: Kurt Jaeger <lists@opsec.eu>
To: Ganbold Tsagaankhuu <ganbold@gmail.com>
Cc: freebsd-ports@freebsd.org
Subject: Re: new port for review: LDAP Authenticator plugin for MySQL
Message-ID: <20160507070925.GA2295@home.opsec.eu>
References: <CAGtf9xOtVGoWsLds3srJEyu9RenDfoYONw4yNJB+gr_T6G5_YA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAGtf9xOtVGoWsLds3srJEyu9RenDfoYONw4yNJB+gr_T6G5_YA@mail.gmail.com>
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports/>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 07 May 2016 07:09:27 -0000

Hi!

> Can anyone take a look or review new port at
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=208913 ?
> This is LDAP Authenticator plugin for MySQL.

One important thing: new ports should be submitted as shar-file.

There are several issues, which running

	cd <port>
	portlint -AC

flags. One other thing that sticks out: Is it really necessary to have
the ateam prefix for the port ?

I've added a shar of the modified port to the PR, which still
does not yet fetch and build. Can you provide a version 1.0
on github that we can fetch ?

Btw, I've created the shar with:

shar `find mysql-ldap-auth -print` > /tmp/ldap.shar

-- 
pi@opsec.eu            +49 171 3101372                         4 years to go !