From owner-freebsd-testing@FreeBSD.ORG Mon Mar 10 23:32:17 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 32E2C292 for ; Mon, 10 Mar 2014 23:32:17 +0000 (UTC) Received: from mail-qa0-f46.google.com (mail-qa0-f46.google.com [209.85.216.46]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id DF487F78 for ; Mon, 10 Mar 2014 23:32:16 +0000 (UTC) Received: by mail-qa0-f46.google.com with SMTP id i13so7578482qae.19 for ; Mon, 10 Mar 2014 16:32:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=LPGlqhXj0BeS2VjxGPhXuTwrN45RefmYF3GLAeoaxBk=; b=PXIfltNUksAreFikbJUnj/6vSZsjQbcvRrVxzO1yqtS0nxkWv8zYaUl4K0LlHfp6ZH Iajv8mzgGup5ZzFdBGZQ0amnPAiQngerpl7SlgWz+PU4xNnleYEi5zPJv8fgHZ/8pZ2X waWz2+13tBR8HwlEKxW4JHjASW50Qzn7kvu4j2lhh300Byd7IGwIyRbdqrwDIYespaax DCzuEbNC90dPeFgghgHhWRgeisfNyQOrwj2rik2+C7XOlGqx81xRc36B60+y4esgTmxR CSkhhAepZGLSSNddURWzOtClJzfsBBfMo4ykRtyoxu8PTzx+bPXgcQY2UVR59WcQ0iJ6 HUOg== X-Gm-Message-State: ALoCoQl806t7zq9HW5HJwdiz7IgWm15Jost2nujvvdIkmXgGgNFPT4iKBvcG8/To8Qv8U+VyeKgp X-Received: by 10.140.102.2 with SMTP id v2mr6732437qge.27.1394488452990; Mon, 10 Mar 2014 14:54:12 -0700 (PDT) MIME-Version: 1.0 Sender: jmmv@meroh.net Received: by 10.96.83.102 with HTTP; Mon, 10 Mar 2014 14:53:51 -0700 (PDT) X-Originating-IP: [2620:0:1003:1021:95e6:6843:a3da:2d60] In-Reply-To: References: <94D3F60A-1E12-418B-8313-E43C93878B95@gmail.com> <56D809A7-5387-475A-8C89-794E328F6935@gmail.com> From: Julio Merino Date: Mon, 10 Mar 2014 17:53:51 -0400 X-Google-Sender-Auth: jGmz6fZShN7Aw36a16z7hUulYkc Message-ID: Subject: Re: [PATCH] Integrate pjdfstest into the build To: Garrett Cooper Content-Type: text/plain; charset=ISO-8859-1 Cc: "freebsd-testing@freebsd.org" , Pawel Jakub Dawidek X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Mar 2014 23:32:17 -0000 On Mon, Mar 3, 2014 at 1:22 PM, Garrett Cooper wrote: > On Sun, Mar 2, 2014 at 3:00 PM, Julio Merino wrote: >> Then I believe this should really live under contrib/pjdfstest. Any >> reason it's not there? If it's external, then yes, we should keep the >> layout of the upstream sources without performing any renames (unless >> Pawel wants to do them). > > I think it should be, but I don't own pjdfstest ;).. > (largely for jmmv's benefit) Ultimately if pjd went this route, > pjdfstest needs to be put in the vendor repo, reimported into FreeBSD > under contrib, and then linked into the tree appropriately. pjd and I discussed this over IRC and he says that this is fine as long as the main structure of pjdfstest is maintained. Ensuring the structure is, arguably, the whole point of putting the code into contrib so this is not a problem. So, we should: 1. Import pjdfstest under a vendor repository. 2. Merge pjdfstest into contrib/pjdfstest/. 3. Add reachover Makefiles and the configuration file somewhere under tests/sys/ (?). 4. Remove all of tools/regression/pjdfstest/. 5. Plug into the test suite! I'll put this in my to-do queue so, eventually, I will get to it... but if any of you can do so instead the better :-)