From owner-freebsd-current@FreeBSD.ORG Thu Dec 8 06:08:43 2005 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BED6C16A41F; Thu, 8 Dec 2005 06:08:43 +0000 (GMT) (envelope-from ai@bmc.brk.ru) Received: from stalker.bmc.brk.ru (stalker.bmc.brk.ru [217.150.59.166]) by mx1.FreeBSD.org (Postfix) with ESMTP id 186B943D7E; Thu, 8 Dec 2005 06:08:40 +0000 (GMT) (envelope-from ai@bmc.brk.ru) Date: Thu, 8 Dec 2005 09:08:35 +0300 From: Artemiev Igor To: freebsd-current@freebsd.org Message-Id: <20051208090835.471a5584.ai@bmc.brk.ru> In-Reply-To: <200512070816.46165.jhb@freebsd.org> References: <20051206093020.691e1483.ai@bmc.brk.ru> <200512070816.46165.jhb@freebsd.org> Organization: Bryansk Medical Center X-Mailer: Sylpheed version 2.0.0beta4 (GTK+ 2.6.8; i386-portbld-freebsd5.4) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Subject: Re: [PATCH] nForce2 SMBus support X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Dec 2005 06:08:43 -0000 On Wed, 7 Dec 2005 08:16:44 -0500 John Baldwin wrote: > On Tuesday 06 December 2005 01:30 am, Artemiev Igor wrote: > > I add pseudo-device amdpmsub because nForce2 have two SMBus > > interfaces. Patch here: > > > > http://bmc.brk.ru/~ai/patches/amdpm.nforce2_support.diff > > > > dmesg output: > > > > amdpm0: port > > 0xdc00-0xdc1f,0x5000-0x501f,0x5500 -0x551f irq 5 at device 1.1 on > > pci0 smbus0: on amdpm0 > > smb0: on smbus0 > > amdpmsub0: on amdpm0 > > smbus1: on amdpmsub0 > > smb1: on smbus1 > > > > I`ve tested it with xmbmon and all works fine. > > Is there any reason you can't make smbus1 a childof amdpm0 directly > and skip the amdpmsub0 device? I simply do not see any way to do it with current implementation of ampdm(and also viapm, etc) & smbus, without modifying the smb->smbus->smbus driver interface. I may be wrong, but as far as I know, currently it's one smb for one driver (smbus_* limitation) -- iprefetch ai