From owner-svn-ports-head@freebsd.org Fri Apr 13 20:13:42 2018 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 33E8BFA41DC for ; Fri, 13 Apr 2018 20:13:42 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: from mail-io0-x22b.google.com (mail-io0-x22b.google.com [IPv6:2607:f8b0:4001:c06::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B3ABE7AF8E for ; Fri, 13 Apr 2018 20:13:41 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: by mail-io0-x22b.google.com with SMTP id t123so4384482iof.7 for ; Fri, 13 Apr 2018 13:13:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sunpoet-net.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=iKc+lSww95jZfS4TUovtlsc7ktNkE1gx8ILLYycC26s=; b=rZqoSxvjYv3UlwzJVLC2AChw65vjJtItmFD7CuZ+pKaynXPILF19mUE2T678oKnPb9 xCR+TnKwuoeK1YPcxBlBXR6pqSmFJe5c1EU9WDjja3Edxy7Vt5/J9BsoOiDy65FbR3Aw Ap14ErljHdR3fJynCbgJRWee3CmD1IsvmiqobqVu0ezHGenF0xVtMrES/J6FxUQR3NRk HB2z8MtO3CCx1Fiwk8Mp5hsZtlAcRE/k3uOtz1S1QhRsopi0/bWbfsR0ISJxMuCHVK0S 8+Ki5CbqDsSHpkhe00bDQSyo13Ay4720w8MBQToC5olCnrRQvV56kCGczSezId45u/Qr DXVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=iKc+lSww95jZfS4TUovtlsc7ktNkE1gx8ILLYycC26s=; b=OG9CFoVOTsQCrmFRViIV9SZIYkTVqCeBTE/rKVJQpTiNri6rC8cz4Yrc8B34laoQ3M liHRHvOcolYnJhZNtgDVsMoY6jD1A9yQvTec7fA6U90Uyii0evcTaUX1sMuPfeOUb+Lh HUhJOwRK0tGLtqTCrWKi2EA3Tb5PoEZMZeqdjlXDe0tmNqw+7zhw8a9EbQP7Ba9VpDVz meLHIKYb36JIl0av7QL9b3Ih3ONZXvb4SHLoET6h0hRQmKHo/AYqgZiLDaiGxaa95lcZ cowKxqiLYV59fUbGRYU/XtM8EsHObByJW1Z9N+LmBnr57pmzqZWfPHLETkRO/AJsN8sY Xvkg== X-Gm-Message-State: ALQs6tBibsmQ+Mg49w0hV6MJLhnIpbsO1VlDM4yaMu7TY96XP9LOiasM /aI7a3zzhfbXZ1tgsl0xyTMUBxdgjKZlLy1SBb6qgA== X-Google-Smtp-Source: AIpwx4+t4zWQzn8+U1Jq08hh7OeXQoSVL5Ie8IKiXjxpPTeCn4jsK0xcUqktVOHuA0RK3VzgyiWhuSeRSzzWrGQ83fc= X-Received: by 10.107.90.14 with SMTP id o14mr14610130iob.148.1523650420974; Fri, 13 Apr 2018 13:13:40 -0700 (PDT) MIME-Version: 1.0 Sender: sunpoet@sunpoet.net Received: by 10.2.57.13 with HTTP; Fri, 13 Apr 2018 13:13:00 -0700 (PDT) In-Reply-To: <86o9inrzzk.fsf@phe.ftfl.ca> References: <201804121833.w3CIXtgW077267@repo.freebsd.org> <431aaec9-51c2-c0c9-7a1f-2f29f79edb5d@fechner.net> <20180413100736.GA32041@FreeBSD.org> <86o9inrzzk.fsf@phe.ftfl.ca> From: Sunpoet Po-Chuan Hsieh Date: Sat, 14 Apr 2018 04:13:00 +0800 X-Google-Sender-Auth: Vmvptd8RqA8EbYvrMgtXKBZ86_U Message-ID: Subject: Re: svn commit: r467193 - in head/www/gitlab: . files To: Joseph Mingrone Cc: Matthias Fechner , Alexey Dokuchaev , Torsten Zuehlsdorff , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Apr 2018 20:13:42 -0000 On Fri, Apr 13, 2018 at 9:35 PM, Joseph Mingrone wrote: > Matthias Fechner writes: > > Dear sunpoet, > > > Am 12.04.2018 um 20:33 schrieb Sunpoet Po-Chuan Hsieh: > >> Log: > >> Fix Gemfile for rubygem-default_value_for 3.1.0 update > > >> - Bump PORTREVISION for package change > > >> Modified: > >> head/www/gitlab/Makefile > >> head/www/gitlab/files/patch-Gemfile > > I really enjoy your work and it is totally fine for me, if you upgrade = a > > gem that you copy the old one and make sure that gitlab uses the old. > > (like you did with r467106, thanks a lot for this!) > > > But please do not start to patch the Gemfile! > > This will break gitlab. Have you tested gitlab with this modification? > > (for sure not, I reported exactly that version of default_value_for > > upstream and they rolled back the change as it broke gitlab, they broke > > 3.0.4 and rolled back the modification with 3.0.5, now you changed > > gitlab to use the version that for sure will not work!) > > > Please revert this modification and ask me (the maintainer) before you > > start to modify the port I maintain. > > Thanks a lot that you understand this. > > > Gru=C3=9F > > Matthias > > I relate. Sunpoet, I also appreciate your work, but this type of > breakage can be frustrating. We need to figure out a solution. > Hi, As I replied before, I'll keep the Gemfile unchanged. The rubygem ports will follow the version requirement in Gemfile. In fact, I stored the Gemfiles of gitlab, mastodon and vagrant in a specific directory. When I update a rubygem port, I check the dependent ports to see if they accepts the newer version. Regards, sunpoet > > On 13.04.2018 12:07, Alexey Dokuchaev wrote: > >> I don't quite understand how/why would anyone in their right mind writ= e > >> software than breaks when one of its dependencies have *minor* version > >> bump? Is this specific to Gitlab, or the nature of Gemfiles is really > >> that broken? > > This practice seems to be more common and in the extreme case, exact > versions of all components are specified. A few examples that come to > mind other than Ruby Gems (with Bundler) are node and Haskell's stack. > > To match what upstream is requesting, I have wondered if the ability to > specify maximum versions would be useful. > > RUN_DEPENDS=3D > rubygem-default_value_for>=3D3.0.1<3.1:devel/rubygem-default_value_for > > The added complexity is probably not worth it for the ability to run > this sort of test. > > devel/rubygem-default_value_for % check_update_breaks_something > *** DANGER, DANGER *** www/gitlab requires devel/rubygem-default_value_fo= r > < 3.1 ! > > A less drastic approach would be to add PORTSCOUT entries to prevent > premature Gem port updates. In this case > > PORTSCOUT=3D limit:^3\.0 > in devel/rubygem-default_value_for/Makefile > Could this work for everyone? > J. >