From owner-freebsd-stable  Sun Sep 24  8:47: 7 2000
Delivered-To: freebsd-stable@freebsd.org
Received: from rover.village.org (rover.village.org [204.144.255.49])
	by hub.freebsd.org (Postfix) with ESMTP id 103B937B422
	for <stable@FreeBSD.ORG>; Sun, 24 Sep 2000 08:47:05 -0700 (PDT)
Received: from billy-club.village.org (billy-club.village.org [10.0.0.3])
	by rover.village.org (8.9.3/8.9.3) with ESMTP id JAA19882;
	Sun, 24 Sep 2000 09:47:02 -0600 (MDT)
	(envelope-from imp@billy-club.village.org)
Received: from billy-club.village.org (localhost [127.0.0.1]) by billy-club.village.org (8.11.0/8.8.3) with ESMTP id e8OFkHG01180; Sun, 24 Sep 2000 09:46:18 -0600 (MDT)
Message-Id: <200009241546.e8OFkHG01180@billy-club.village.org>
To: BSD <bsd@shell-server.com>
Subject: Re: Constant panics on 4.1-STABLE! 
Cc: Michael Allman <msa@dinosauricon.com>, stable@FreeBSD.ORG
In-reply-to: Your message of "Sat, 23 Sep 2000 23:20:02 CDT."
		<Pine.BSF.4.10.10009232316590.62035-100000@marvin.shell-server.com> 
References: <Pine.BSF.4.10.10009232316590.62035-100000@marvin.shell-server.com>  
Date: Sun, 24 Sep 2000 09:46:17 -0600
From: Warner Losh <imp@village.org>
Sender: owner-freebsd-stable@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

In message <Pine.BSF.4.10.10009232316590.62035-100000@marvin.shell-server.com> BSD writes:
: On Wed, 20 Sep 2000, Michael Allman wrote:
: > 132		/*
: > 133		 * Look up the address in the table for that Address Family
: > 134		 */
: > 135		if (rnh && (rn = rnh->rnh_matchaddr((caddr_t)dst, rnh)) &&
: > 136		    ((rn->rn_flags & RNF_ROOT) == 0)) {
: 
: 	C doesn't guarantee order of execution in if ( bleh && bleh &&
: bleh).  It may very well evaluate it backwards, or from the inside out if
: it wants.  No?

No.  That's not right.  It evaluates left to right.  rnh is checked
for null, then matchaddr is called and then rn->rn_flags is checked.

Warner


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-stable" in the body of the message