Date: Fri, 3 Aug 2018 09:50:22 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Alexander Leidinger <netchild@freebsd.org> Cc: Jan Beich <jbeich@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r476193 - in head/audio/lame: . files Message-ID: <20180803075022.kmcp7v32gawzkzrx@atuin.in.mat.cc> In-Reply-To: <20180802150102.Horde.s6KtHYgokNv3W8TM8Bd94eE@webmail.leidinger.net> References: <201808012001.w71K1Slh060704@repo.freebsd.org> <muu5-ome2-wny@FreeBSD.org> <20180802150102.Horde.s6KtHYgokNv3W8TM8Bd94eE@webmail.leidinger.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--y66fbjy3fe6jjht5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 02, 2018 at 03:01:02PM +0200, Alexander Leidinger wrote: >=20 > Quoting Jan Beich <jbeich@freebsd.org> (from Wed, 01 Aug 2018 22:35:49 +0= 200): >=20 > > Alexander Leidinger <netchild@FreeBSD.org> writes: > >=20 > > > Author: netchild > > > Date: Wed Aug 1 20:01:27 2018 > > > New Revision: 476193 > > > URL: https://svnweb.freebsd.org/changeset/ports/476193 > > >=20 > > > Log: > > > Move patents text from the Makefile to a file. > > > While I'm here, make it more an explanatory text than just a > > > copy&paste from the previous comment of the Makefile. > > >=20 > > > Requested by: portmgr (mat) > > [...] > > > +LICENSE_FILE_PATENTS=3D $(FILESDIR)/lame_patents.txt > >=20 > > $(...) isn't consistent with the rest of the file. >=20 > Ooops. >=20 > > $ portlint -C > > WARN: Makefile: [18]: use ${VARIABLE}, instead of $(VARIABLE). > > FATAL: Makefile: LICENSE_NAME_PATENTS appears out-of-order. > > FATAL: Makefile: LICENSE_FILE_PATENTS appears out-of-order. > > FATAL: Makefile: order must be LICENSE/LICENSE_COMB/LICENSE_GROUPS(_\w+= )?/LICENSE_NAME(_\w+)?/LICENSE_TEXT(_\w+)?/LICENSE_FILE(_\w+)?/LICENSE_PERM= S(_\w+)?/LICENSE_DISTFILES(_\w+)?. > > 3 fatal errors and 1 warning found. >=20 > May I challenge the order? LICENSE shall be ordered alphabetically, and t= hen > we mix the patent grouped parts... Looks strange to me. If you look at the > result after your patch, it goes to PATENTS, then LGPL then PATENTS again. > For me the natural grouping is per license, so first all the variables for > the first license, then all for the second. Alphabetical order is off cou= rse > easy to implement in tools like portlint, and easy so teach to maintainer= s, > but for the Mk files it doesn't matter, and in my opinion we should change > that to group per license, as it is less context-switching from one licen= se > to another for the person which looks at multi-license ports. Thank you for your input. We already have an existing order, documented in: https://www.freebsd.org/doc/en/books/porters-handbook/porting-order-license= =2Ehtml Please help keep the ports tree coherent by keeping to it. Kind regards, --=20 Mathieu Arnold --y66fbjy3fe6jjht5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAltkCT1fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zki/exAAh+pkvtc+LSEzr7d0qUe4gAZs8jL6l+xIeI0j9ZzPBPAYreuIykDeXQ4X /+568meaNLBeSgxDnk95nFh/b6nxXC/tK8SUrdG5FHpAf2LtSaQ8xyZUCNiBlmhN WnukSjyJpLBRs6eoVP8AKFwdPUnFnoaZ1Fx7MNrHnVEQROv2WD3qt/9OPUiJxaCa Ki8LJUTZkzzclpMicOdEUbf4uhKEUogK74AQJHqGHNkxUP8ZijH7YsWC6OA4vy3C hicqj0ohQKhveyLXBYs+CCDxSqr+ojY7zKYNFADjiF4PSpAo59JAD3rXPpmrPGWz uugi6/H6PyiXgtmAyGvlB+K0NfeYxlmIkMo0SKtmC+2/L+42eqM18dCWrhYnP54p LJrBMLfGNMysZbm5XuBPBp1op82hdjPP+8eorOwwcLM+B+O+KIZ1l0IGI7NaOYVd wajYZybWfskEQbdCXbClFhAysRT6AiJQ5Sue/u3OdFk/k4tqWdKymGoZD+KmEtkW jBLr777/uBhOIy7SwIeA+UqAet2gp+JmNgzjWH6gRbz5DsNivs/rMCJabdgtmprq BTrwCZVGM3w41PZamzlibP6/v8PK+Ztx7m3GfPxO9Ygbd7gW7YvlLuPLWpNt2C37 uiS+Is2Mll1jh4QrbibYTv3ptMi6kOuWgsAUMH/JN3UvAv3UV3w= =hieJ -----END PGP SIGNATURE----- --y66fbjy3fe6jjht5--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180803075022.kmcp7v32gawzkzrx>