From owner-dev-commits-ports-all@freebsd.org  Thu Sep 30 19:50:25 2021
Return-Path: <owner-dev-commits-ports-all@freebsd.org>
Delivered-To: dev-commits-ports-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id BE0F06B6F28;
 Thu, 30 Sep 2021 19:50:25 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4HL3kT4ndkz4m05;
 Thu, 30 Sep 2021 19:50:25 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim;
 t=1633031425;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=vmUD0+uXLJIwiYrEw07C9ZjFOHjql9/mZIFu7ei6T6I=;
 b=RCr47h1Yt2SIZxkR9b6fl4BwHnEIzbZ6KogFnukrHvJes0e0vBz9H2mW1fJj4RRhsFCVs6
 BDuSRzrYfhToHHQvzY/Ih3dIGVKzXuaAOxarW3yCCiwe3aAgCgTV4lv4CdSbfKsxSmQnPq
 01Lj8zkCVp0D4J0fA03XaiNGSCRnh+HQ4LlDVTi597inBhvo/ZQhJEaEAx4xEFBTy0fxFO
 dysb9ELKk8Fo4C0n+KtxA9XEriWPDDj5F+wJtL5mfDK9j3qTAJS0ocLlEAOz2VAHS3xwrx
 9DiK6O+OCidV1JIpKSYOE0nCS+A7kGZd2r3ksD6MfJ2ncHplmcpekmV3jHdudQ==
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id 9262A17AF4; Thu, 30 Sep 2021 19:50:25 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: Piotr Kubaj <pkubaj@FreeBSD.org>
Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org,
 dev-commits-ports-main@FreeBSD.org
Subject: Re: git: fc75da3a3b2a - main - graphics/libjxl: fix build on
 powerpc64*
References: <202109301550.18UFoo8j096475__2724.79643333412$1633017067$gmane$org@gitrepo.freebsd.org>
Date: Thu, 30 Sep 2021 21:50:21 +0200
In-Reply-To: <202109301550.18UFoo8j096475__2724.79643333412$1633017067$gmane$org@gitrepo.freebsd.org>
 (Piotr Kubaj's message of "Thu, 30 Sep 2021 15:50:50 GMT")
Message-ID: <y27d-6dxe-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org;
 s=dkim; t=1633031425;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=vmUD0+uXLJIwiYrEw07C9ZjFOHjql9/mZIFu7ei6T6I=;
 b=OInbu+wEWVpGV5pzrjPCmGv+z9RP+fUEcKkwdCkJPZSWYMGlLFIOd+6xAwTaJfGE5BiudQ
 yt72+uqhUszyiw5AXBl9v2tyXohBwrr0vcqFHG8C8DJz+XruVCROBkUGjWB7e3kylXUulZ
 LqoPYJ37vQ22u6qWGRUV+Q1vtcC9nLAJLxtPRxFpSm0PNixPp2wYNr/tcyn4DlbI1Wd9VA
 WgnpA0FHZzkFRCy5IhNlt0HVvjsEV7N+S7efh3xGQ+ThXj3t/0bRVsnogJp2WNyLzFRaXY
 gisjjygrygYr4m3M6OcZYJz6KjzlEBxxl5+7r9uJV6SIU3ZPHyIJuRTB81a1xg==
ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1633031425; a=rsa-sha256; cv=none;
 b=Fr4L6ZGg21m0Knn00hGnn2Bg2MottHn6TLyuA+wdIO3UYKyc5zuAsAG8Ky3itjYaYN7Dvr
 OFU4qvl69Ju1+xp1QsXzezead8ZR1LDoFuh/r/KGGHhd3oSl73vlqW9u/2TFJJN32TPADy
 z7GhOfYjixCLax2fuEmfq2FS3fG+Ow2YPLRH+Egoc3Dl5zPH3bKmwqJtskHPcaQRoBZ6b5
 pZW4xpmKH3L1Q5ZKhwlp9jD8ilf5BBMn74HLGVv5YBqu1mQgonfGkSnloU5FpmfZPUWaOF
 J/HwoLSv8ADRQ0OBkvPr8J8XsxDw4uO87zZZwQwXDnjd9OGQSW8htqm1sSbZZQ==
ARC-Authentication-Results: i=1;
	mx1.freebsd.org;
	none
X-BeenThere: dev-commits-ports-all@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commit messages for all branches of the ports repository
 <dev-commits-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-ports-all>, 
 <mailto:dev-commits-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-ports-all/>
List-Post: <mailto:dev-commits-ports-all@freebsd.org>
List-Help: <mailto:dev-commits-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-ports-all>, 
 <mailto:dev-commits-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Sep 2021 19:50:25 -0000

Piotr Kubaj <pkubaj@FreeBSD.org> writes:

>     The include in cpu.cc is not actually necessary, so I did not include anything for FreeBSD.
[...]
> +--- tools/cpu/cpu.cc.orig	2021-09-30 15:38:45 UTC
> ++++ tools/cpu/cpu.cc
> +@@ -19,7 +19,9 @@
> + #endif
> + 
> + #if JXL_ARCH_PPC
> +-#include <sys/platform/ppc.h>  // __ppc_get_timebase_freq
> ++#if linux
> ++#include <sys/platform/ppc.h>  // NOLINT __ppc_get_timebase_freq
> ++#endif
> + #endif

Can you file a bug via https://github.com/libjxl/libjxl/issues/new ?
That include is probably unused even on Linux after 5175d11717f3
removed __ppc_get_timebase_freq.

Note, if you can't sign Google CLA don't submit a fix. Otherwise, upstream
will refuse to read the rationale (PR description), let alone the patch e.g.,
https://github.com/libjxl/libjxl/pull/193