From owner-freebsd-current@FreeBSD.ORG Fri Jun 14 16:35:04 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 34D65D7; Fri, 14 Jun 2013 16:35:04 +0000 (UTC) (envelope-from luigi@onelab2.iet.unipi.it) Received: from onelab2.iet.unipi.it (onelab2.iet.unipi.it [131.114.59.238]) by mx1.freebsd.org (Postfix) with ESMTP id EED741A3E; Fri, 14 Jun 2013 16:35:03 +0000 (UTC) Received: by onelab2.iet.unipi.it (Postfix, from userid 275) id 724097300A; Fri, 14 Jun 2013 18:38:12 +0200 (CEST) Date: Fri, 14 Jun 2013 18:38:12 +0200 From: Luigi Rizzo To: John Baldwin Subject: Re: copyin()/copyout() constraints ? Message-ID: <20130614163812.GA50980@onelab2.iet.unipi.it> References: <20130612180115.GA27892@onelab2.iet.unipi.it> <51B8BFC4.303@mu.org> <201306141207.29779.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201306141207.29779.jhb@freebsd.org> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: freebsd-current@freebsd.org, Alfred Perlstein X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jun 2013 16:35:04 -0000 On Fri, Jun 14, 2013 at 12:07:29PM -0400, John Baldwin wrote: > On Wednesday, June 12, 2013 2:36:52 pm Alfred Perlstein wrote: > > On 6/12/13 11:01 AM, Luigi Rizzo wrote: > > > hi, > > > is it possible to run copyin() or copyout() in one of these cases: > > > 1. while holding a spinlock > > > 2. while holding a regular mutex/lock > > > 3. while holding a read lock (on an RWLOCK or RMLOCK) > > > 4. while holding a write lock (on an RWLOCK or RMLOCK) > > > > > > I suspect #1 is forbidden, but am a bit unclear for the > > > other cases. > > No on all of the above unless the memory is wired. ok i suppose i'll move to an sx lock, which i have been told allows me to sleep ? My use case is that while i run the copyin(), and possibly take a page fault, nobody destroys the destination buffer. So i wanted to hold a read lock (sx_slock() ?) in the thread doing the copy (there may be several writers to different parts of the destination), and a write lock (sx_xlock() ?) for the other thread which may destroy the buffer. cheers luigi